From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>,
Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
Cc: intel-xe@lists.freedesktop.org,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Piotr Piórkowski" <piotr.piorkowski@intel.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Michał Winiarski" <michal.winiarski@intel.com>,
"Dunajski Bartosz" <bartosz.dunajski@intel.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [RFC v6 1/1] drm/xe/pf: Restrict device query responses in admin-only PF mode
Date: Wed, 25 Mar 2026 09:38:51 +0100 [thread overview]
Message-ID: <8d140cfb-ad38-4548-aec0-89581c79d8e5@intel.com> (raw)
In-Reply-To: <875x6lq64y.wl-ashutosh.dixit@intel.com>
On 3/24/2026 10:17 PM, Dixit, Ashutosh wrote:
> On Sun, 15 Mar 2026 23:41:02 -0700, Satyanarayana K V P wrote:
>>
>> ---
>> V5 -> V6:
>> - Updated commit message.
>> - Return number of engines and memory regions as zero instead of returning
>> query size as zero (Michal Wajdeczko).
>> - Allow all other query IOCTLs excepts query_engines and query_mem_regions
>> (Michal Wajdeczko).
>
> Can someone explain the reason to move away from the approach in v5? Afais
> v6 has issues of this sort:
>
> * query_engines will return 0 engines but query_hwconfig will return > 0
> engines
but those are separate queries on purpose, right?
and I guess that even today there could be a mismatch between these numbers:
* query_engines = engines available for use by the user software
* query_hwconfig.engines = report engines present on the hardware
> * query_engines will return 0 engines but query_oa_units will list out the
> engines
and that IMO should be considered as a desired outcome, as I guess (again)
that this will allow us to do some OA reporting, even if PF alone is not
submitting any workloads and we want to monitor how VFs are doing
> * query_oa_units will return valid oa support but observation ioctl will
> fail
my initial idea [1] was to expose observation ioctl as well, maybe we need
to add it back?
[1] https://patchwork.freedesktop.org/patch/706445/?series=160349&rev=2#comment_1299475
>
> v5 seems to have avoided contradictions of this sort. Or this doesn't
> matter? Thanks.
but since I'm not using any of those ioctls on daily basis, I might be wrong
next prev parent reply other threads:[~2026-03-25 8:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 6:41 [RFC v6 0/1] Do not create drm device for PF only admin mode Satyanarayana K V P
2026-03-16 6:41 ` [RFC v6 1/1] drm/xe/pf: Restrict device query responses in admin-only PF mode Satyanarayana K V P
2026-03-23 22:03 ` Rodrigo Vivi
2026-03-24 21:17 ` Dixit, Ashutosh
2026-03-25 5:21 ` K V P, Satyanarayana
2026-03-25 13:11 ` Rodrigo Vivi
2026-03-25 8:38 ` Michal Wajdeczko [this message]
2026-03-27 5:34 ` Dixit, Ashutosh
2026-03-27 13:26 ` Rodrigo Vivi
2026-03-16 6:47 ` ✓ CI.KUnit: success for Do not create drm device for PF only admin mode (rev5) Patchwork
2026-03-16 7:27 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-17 8:16 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d140cfb-ad38-4548-aec0-89581c79d8e5@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=bartosz.dunajski@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=michal.winiarski@intel.com \
--cc=piotr.piorkowski@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=satyanarayana.k.v.p@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox