From: "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>, <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe/display: Drop unnecessary xe_gt.h includes
Date: Fri, 30 Aug 2024 16:19:04 +0530 [thread overview]
Message-ID: <8de6bb16-4ecf-4440-9df1-a2fd35c98a95@intel.com> (raw)
In-Reply-To: <20240829230307.886233-2-matthew.d.roper@intel.com>
On 30-08-2024 04:33, Matt Roper wrote:
> None of the Xe display files work directly with the GT or need anything
> from xe_gt.h. Drop the unnecessary include.
>
LGTM.
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/xe/display/intel_fbdev_fb.c | 1 -
> drivers/gpu/drm/xe/display/xe_dsb_buffer.c | 1 -
> drivers/gpu/drm/xe/display/xe_fb_pin.c | 1 -
> drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/display/intel_fbdev_fb.c b/drivers/gpu/drm/xe/display/intel_fbdev_fb.c
> index cd8948c08661..99499d6c0256 100644
> --- a/drivers/gpu/drm/xe/display/intel_fbdev_fb.c
> +++ b/drivers/gpu/drm/xe/display/intel_fbdev_fb.c
> @@ -8,7 +8,6 @@
> #include "intel_display_types.h"
> #include "intel_fbdev_fb.h"
> #include "xe_bo.h"
> -#include "xe_gt.h"
> #include "xe_ttm_stolen_mgr.h"
> #include "xe_wa.h"
>
> diff --git a/drivers/gpu/drm/xe/display/xe_dsb_buffer.c b/drivers/gpu/drm/xe/display/xe_dsb_buffer.c
> index ccd0d87d438a..f99d901a3214 100644
> --- a/drivers/gpu/drm/xe/display/xe_dsb_buffer.c
> +++ b/drivers/gpu/drm/xe/display/xe_dsb_buffer.c
> @@ -9,7 +9,6 @@
> #include "xe_bo.h"
> #include "xe_device.h"
> #include "xe_device_types.h"
> -#include "xe_gt.h"
>
> u32 intel_dsb_buffer_ggtt_offset(struct intel_dsb_buffer *dsb_buf)
> {
> diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> index d650c5ac41a4..b58fc4ba2aac 100644
> --- a/drivers/gpu/drm/xe/display/xe_fb_pin.c
> +++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> @@ -12,7 +12,6 @@
> #include "xe_bo.h"
> #include "xe_device.h"
> #include "xe_ggtt.h"
> -#include "xe_gt.h"
> #include "xe_pm.h"
>
> static void
> diff --git a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> index 0af667ebebf9..6619a40aed15 100644
> --- a/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> +++ b/drivers/gpu/drm/xe/display/xe_hdcp_gsc.c
> @@ -16,7 +16,6 @@
> #include "xe_force_wake.h"
> #include "xe_gsc_proxy.h"
> #include "xe_gsc_submit.h"
> -#include "xe_gt.h"
> #include "xe_map.h"
> #include "xe_pm.h"
> #include "xe_uc_fw.h"
next prev parent reply other threads:[~2024-08-30 10:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 23:03 [PATCH] drm/xe/display: Drop unnecessary xe_gt.h includes Matt Roper
2024-08-29 23:09 ` ✓ CI.Patch_applied: success for " Patchwork
2024-08-29 23:09 ` ✓ CI.checkpatch: " Patchwork
2024-08-29 23:10 ` ✓ CI.KUnit: " Patchwork
2024-08-29 23:22 ` ✓ CI.Build: " Patchwork
2024-08-29 23:25 ` ✓ CI.Hooks: " Patchwork
2024-08-29 23:26 ` ✓ CI.checksparse: " Patchwork
2024-08-29 23:45 ` ✓ CI.BAT: " Patchwork
2024-08-30 10:49 ` Ghimiray, Himal Prasad [this message]
2024-08-30 14:55 ` ✗ CI.FULL: failure " Patchwork
2024-08-30 16:00 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8de6bb16-4ecf-4440-9df1-a2fd35c98a95@intel.com \
--to=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox