Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John Harrison <john.c.harrison@intel.com>
To: Stuart Summers <stuart.summers@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <lucas.demarchi@intel.com>
Subject: Re: [PATCH] drm/xe: Don't print error about hwconfig when using execlists
Date: Fri, 28 Mar 2025 09:08:36 -0700	[thread overview]
Message-ID: <8e81c5a0-8bb7-41bd-bb38-db261b2f6a69@intel.com> (raw)
In-Reply-To: <20250328154236.9216-1-stuart.summers@intel.com>

On 3/28/2025 8:42 AM, Stuart Summers wrote:
> This error message is only applicable for platforms using
> GuC submission - to warn the user if the GuC they are using
> or the platform they are running doesn't have this information
> to provide to userspace about the platform. When forcing
> execlist submission, which is something only used for debug,
> the user is running at their own risk and should understand
> the limitations of running without GuC.
>
> v2 (John/Lucas): Don't print an info message with execlists
>
> Signed-off-by: Stuart Summers <stuart.summers@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

> ---
>   drivers/gpu/drm/xe/xe_gt_mcr.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.c b/drivers/gpu/drm/xe/xe_gt_mcr.c
> index 605aad3554e7..d4d9730f0d2c 100644
> --- a/drivers/gpu/drm/xe/xe_gt_mcr.c
> +++ b/drivers/gpu/drm/xe/xe_gt_mcr.c
> @@ -345,7 +345,8 @@ static unsigned int dss_per_group(struct xe_gt *gt)
>   	 * Some older platforms don't have tables or don't have complete tables.
>   	 * Newer platforms should always have the required info.
>   	 */
> -	if (GRAPHICS_VERx100(gt_to_xe(gt)) >= 2000)
> +	if (GRAPHICS_VERx100(gt_to_xe(gt)) >= 2000 &&
> +	    !gt_to_xe(gt)->info.force_execlist)
>   		xe_gt_err(gt, "Slice/Subslice counts missing from hwconfig table; using typical fallback values\n");
>   
>   	if (gt_to_xe(gt)->info.platform == XE_PVC)


  parent reply	other threads:[~2025-03-28 16:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28 15:42 [PATCH] drm/xe: Don't print error about hwconfig when using execlists Stuart Summers
2025-03-28 15:47 ` ✓ CI.Patch_applied: success for " Patchwork
2025-03-28 15:47 ` ✓ CI.checkpatch: " Patchwork
2025-03-28 15:49 ` ✓ CI.KUnit: " Patchwork
2025-03-28 16:05 ` ✓ CI.Build: " Patchwork
2025-03-28 16:08 ` ✓ CI.Hooks: " Patchwork
2025-03-28 16:08 ` John Harrison [this message]
2025-03-28 16:09 ` ✓ CI.checksparse: " Patchwork
2025-03-28 16:31 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-28 17:07 ` [PATCH] " Randhawa, Jagmeet
2025-03-29  4:23 ` ✗ Xe.CI.Full: failure for " Patchwork
2025-03-31 14:22 ` [PATCH] " Lucas De Marchi
2025-03-31 14:52   ` Summers, Stuart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e81c5a0-8bb7-41bd-bb38-db261b2f6a69@intel.com \
    --to=john.c.harrison@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=stuart.summers@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox