From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 849CDC48285 for ; Tue, 30 Jan 2024 17:33:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C83E51133E5; Tue, 30 Jan 2024 17:33:27 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0A6011332F; Tue, 30 Jan 2024 17:33:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706636005; x=1738172005; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=XD9IqWzm5oFGyRCEVAHPcbBHSjTstyBuV0UUysWpTqk=; b=DMsktYndaiKlk1ljPj8JIVU7QOp2BazKY7V7EG78lsQxQLA6wDUvqhYd DjPETM6Gjg2sYJO3XvQ51ocOG4cJbFlcJwpPCZ9e9kQ43Rtf0k+XRJXcI JD4CI0DAlHnTOyqeRTIHP2Qk6dqR4PfCl8GJtJtiMEYm81WcaohKLfkME o2njl6coO/ZA7wufzQa7CgRVD0srXY1DuwPyq48yTLHpgtyBohQf7Tvhl 4/JS+87lAm+LN2g2fTy6CqnD3nYqEF2i8B6+sN1rNGIghndDGREQPy1UN QYdgOXnof7Ie0b5gkEIVpoi/WFcJRJWEWAfqQuo2GBVo3sRSIlGaQ9G6f g==; X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="402953048" X-IronPort-AV: E=Sophos;i="6.05,230,1701158400"; d="scan'208";a="402953048" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2024 08:26:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="1119316557" X-IronPort-AV: E=Sophos;i="6.05,230,1701158400"; d="scan'208";a="1119316557" Received: from nkumi-mobl3.ger.corp.intel.com (HELO [10.213.210.105]) ([10.213.210.105]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2024 08:26:12 -0800 Message-ID: <8ea359bb-b794-4585-9d91-fdb866e1d01e@linux.intel.com> Date: Tue, 30 Jan 2024 16:26:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] drm/i915: Update shared stats to use the new gem helper Content-Language: en-US To: Alex Deucher , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, daniel@ffwll.ch References: <20240130161235.3237122-1-alexander.deucher@amd.com> <20240130161235.3237122-6-alexander.deucher@amd.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <20240130161235.3237122-6-alexander.deucher@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 30/01/2024 16:12, Alex Deucher wrote: > Switch to using the new gem shared memory stats helper > rather than hand rolling it. > > Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deucher@amd.com/ > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/i915/i915_drm_client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drm_client.c b/drivers/gpu/drm/i915/i915_drm_client.c > index fa6852713bee..f58682505491 100644 > --- a/drivers/gpu/drm/i915/i915_drm_client.c > +++ b/drivers/gpu/drm/i915/i915_drm_client.c > @@ -53,7 +53,7 @@ obj_meminfo(struct drm_i915_gem_object *obj, > obj->mm.region->id : INTEL_REGION_SMEM; > const u64 sz = obj->base.size; > > - if (obj->base.handle_count > 1) > + if (drm_gem_object_is_shared_for_memory_stats(&obj->base)) > stats[id].shared += sz; > else > stats[id].private += sz; Reviewed-by: Tvrtko Ursulin Good that you remembered this story, I completely forgot! Regards, Tvrtko