From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41E15CD13CF for ; Mon, 2 Sep 2024 08:49:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DEA610E262; Mon, 2 Sep 2024 08:49:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="jI4qn8wc"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 66CA510E259; Mon, 2 Sep 2024 08:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725266956; x=1756802956; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=9Wj+2wzibliCuxzZyWPyPWMg3OD23kyW+0P1Z8qTaC0=; b=jI4qn8wch35179v47uT3BtY8ywt7zlaSweVlRpLb9i7IFU9CGoOBsVTk iqT5igSSLc1H8weHRZf8eALke+0qQbJmceRuMhy6PBuUErmyMjOz4Fifq b5QcnLPxyn92niTmaLV+fJjQ7eADDa/a08L2+3ZO+2wnmBxyeyvzsO9zF ZMe2I7qHgUwT28EF08ZD71nBGmGNrVqzvhHFKgbFrkCfOXmE/QpSeC+PS 7R0oxtplflUO8PBkXxx9WOwQgoyESr62jwgm6vZGfoKcuu05Ah65SZNik qXX6Cu7Yfg+AzWb5sG9S4CeyvBy42b3Rg4qmLRdwGF4n0C3WyOsGTh7K5 g==; X-CSE-ConnectionGUID: 4eV90TavSd6ovG12boX3Sg== X-CSE-MsgGUID: KeHXQGOqTR296rhPjKV+Bw== X-IronPort-AV: E=McAfee;i="6700,10204,11182"; a="23706721" X-IronPort-AV: E=Sophos;i="6.10,195,1719903600"; d="scan'208";a="23706721" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2024 01:49:16 -0700 X-CSE-ConnectionGUID: WNfUaGuERs+tdCI+2XRvvQ== X-CSE-MsgGUID: O1Zjf5U8SPi6QKi2ASouQQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,195,1719903600"; d="scan'208";a="69352917" Received: from aravind-dev.iind.intel.com (HELO [10.145.162.146]) ([10.145.162.146]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2024 01:49:12 -0700 Message-ID: <9011dfee-3f69-4d80-90e1-efffc6576740@linux.intel.com> Date: Mon, 2 Sep 2024 14:22:21 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] drm/i915: Use device wedged event To: Raag Jadav , airlied@gmail.com, daniel@ffwll.ch, lucas.demarchi@intel.com, thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, tursulin@ursulin.net Cc: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, himal.prasad.ghimiray@intel.com, francois.dugast@intel.com, anshuman.gupta@intel.com, bellekallu.rajkiran@intel.com, saikishore.konda@intel.com References: <20240902074859.2992849-1-raag.jadav@intel.com> <20240902074859.2992849-4-raag.jadav@intel.com> Content-Language: en-US From: Aravind Iddamsetty In-Reply-To: <20240902074859.2992849-4-raag.jadav@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 02/09/24 13:18, Raag Jadav wrote: > Now that we have device wedged event supported by DRM core, make use > of it. With this in place, userspace will be notified of wedged device > on gt reset failure. > > Signed-off-by: Raag Jadav > --- > drivers/gpu/drm/i915/gt/intel_reset.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c > index 735cd23a43c6..60d09ec536c4 100644 > --- a/drivers/gpu/drm/i915/gt/intel_reset.c > +++ b/drivers/gpu/drm/i915/gt/intel_reset.c > @@ -1409,6 +1409,8 @@ static void intel_gt_reset_global(struct intel_gt *gt, > > if (!test_bit(I915_WEDGED, >->reset.flags)) > kobject_uevent_env(kobj, KOBJ_CHANGE, reset_done_event); > + else > + drm_dev_wedged(>->i915->drm); > } rather than intel_gt_reset_global, __intel_get_set_wedged looks to be an appropriate place where actually the device is declared wedged and that would cover all call sites too. Thanks, Aravind. > > /**