From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F347CD4922E for ; Mon, 18 Nov 2024 14:54:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FB1A10E4F8; Mon, 18 Nov 2024 14:54:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=web.de header.i=markus.elfring@web.de header.b="bzPrp7N9"; dkim-atps=neutral X-Greylist: delayed 1009 seconds by postgrey-1.36 at gabe; Sat, 16 Nov 2024 10:41:35 UTC Received: from mout.web.de (mout.web.de [217.72.192.78]) by gabe.freedesktop.org (Postfix) with ESMTPS id C202810E3F2; Sat, 16 Nov 2024 10:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1731753689; x=1732358489; i=markus.elfring@web.de; bh=eoB4Zba0oDILq/GyWjNIQLXHlVmq6QUNlZtjwtBqfrw=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To: References:From:Cc:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=bzPrp7N9YH7r1Ow+YH+3j14mJDRCzfEa+ok6l7myeynbwJ02g+WQLwYMQXJmqwuI crlhKRPapobq0S/EjAMgOh60GpbiSoBq2k5oQ6LWZlj6MIVWU8PLKYjprpb5rBIt9 pFoEoycdZP1jc7sjFi86L5ueroxB2N+r+Gz5w/KaAfr16jOTC87ggm5nQqDtc5E3U a8kMRgAW6z7hjbN7VCuEQkBZ3xGdkFST7ZwayOeTmK0wY1yXq1o11q803irbsCl28 hZslhpQBnA1Uwnkd2c814U8XUMY214y5U59pibzH9D4LdnHSG7ZYJ1XkpkynyCtxA q6MSJAi+pPFbo9vi7g== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.88.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M8kEV-1t87Dv2SuX-00FywX; Sat, 16 Nov 2024 11:23:22 +0100 Message-ID: <9088f9a2-c4ab-4098-a255-25120df5c497@web.de> Date: Sat, 16 Nov 2024 11:23:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [cocci] [PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script To: Easwar Hariharan , cocci@inria.fr References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-2-911fb7595e79@linux.microsoft.com> Content-Language: en-GB From: Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan In-Reply-To: <20241115-converge-secs-to-jiffies-v2-2-911fb7595e79@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ozemPo5Q9OPy+/gWIfbNb/yTAwp7zpbaqzDjn4mcTmOYffBLZAH E0gCP/qnqze9l4Bx97cEhIN2OOovptOgRBkBUi+bKyV+a6ol7S4atoRxVmjqBCc2g41VI8a ROXhUKP5mlUoyzcJqOavJdVAoW8iKSPURqEhcga4JsnmJm/Pjl1vO+foxZw0grHWEblCrYI LJ17n1lYaEdE61JhX5uvg== UI-OutboundReport: notjunk:1;M01:P0:e9ABhU9NZHo=;rgflfceERn082UGqgZC6K7y/G4R xwv4QzMgKy8OsNvu9He9aFcoE/BwuiQP7JQJsiPlsgI4/zJaDy1sYzMdtXfLqWrr5jJ9N4g9U e3F4mh79efIlT4X2C5nuv52ZsyyniIkZbER0pald3bsZc2XtKax7vQOK0kpZQm42VD2KQB4T8 DWCrj311mNY6rlWCLoT6JUZxejPy922e+io6G3gvwQa+oEa5U6WEulIFacoY9Lh8wa1aKeqH6 o+9SoHYQ4cD8PvsmXXt2Gvq9DCmQlbZ5k2V5QR2BGq+tMn5aMcqOQWfHQ/2zetALUatsGQ1t9 RyZmND+OZbbUZ2DNCz/uNrgpJn2KwO7nfoXuHe61XLipaMAObuwJQkd3OLwqrM2PXjI/NAkuj wqmfzjsXwoVDA8NXKUJCnEs0bU0OZcHeP/i+Af/EBomorje7VQzTlOnClwQPZXbgdXb00O8cC 7Rdytirq+y9I7DgnGSzCa1LSUTfbHscCOVc3ucE2iv+dPIhdGsLUEucAcZHoyAYn1p6NqH+KB Y3nwzMoTmM0us91/2eNVk0jASR5WPON4BeWytF195tm8wip8Qe14456uNhgc/ExVWN0iNuL1R jr2rCEDxAIRHrwA9Wdv2W2cbo2OO+dhoMwCULYkz1JgyygsdyUG0ghe3G6ZJTCWn5CLbsdH2D HhOLHzMigxhavYRSRlljQtL/SmgBOASYtVmnYsD7GTPC9VOklkVQgnW4dIvuTBrHlW8VlFhoh PM3EXWpKymw2qTXTqr6pws/QSajrrJb0Pxyjw6x5+pX+Hokr9X/puAKvNI60Ap/AQUUNK7wHO uscCSBCoQaHCRmmTJ9YoLuUEb58BodmGF8yJ++Vcu4nBY2umLUmrRqd5SFa2XYbharitFIbOM 6zxsTQDTtWNNaBb6gWfvj/dHPzFMntgCa9FH5UrMGNefk+UvKfSN3WrfK/k8lljDzTPT3g2Nw sIUSSiBCM7AnJS82ffFhp7HaQF6q18fy63Ccvk1EI8aoKYHziSxPne8lhE77De728HAoSQ== X-Mailman-Approved-At: Mon, 18 Nov 2024 14:54:06 +0000 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Why is a change description missing here? =E2=80=A6 > +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci > @@ -0,0 +1,21 @@ =E2=80=A6 > +/// Find usages of: > +/// - msecs_to_jiffies(value*1000) > +/// - msecs_to_jiffies(value*MSEC_PER_SEC) I suggest to take another look at corresponding development documentation. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/dev-tools/coccinelle.rst?h=3Dv6.12-rc7#n71 Will the attention grow for the proper usage of operation modes according to the tool =E2=80=9Ccoccicheck=E2=80=9D? =E2=80=A6 > +// Copyright: (C) 2024 Easwar Hariharan Microsoft Should personal details and company names be better distinguished in such = information? > +// > +// Keywords: secs, seconds, jiffies May a (blank) comment line be omitted here? > +@@ constant C; @@ > + > +- msecs_to_jiffies(C * 1000) > ++ secs_to_jiffies(C) > + > +@@ constant C; @@ > + > +- msecs_to_jiffies(C * MSEC_PER_SEC) > ++ secs_to_jiffies(C) I suggest to take a SmPL code variant (like the following) better into account. @depends on patch@ constant C; @@ -msecs_to_jiffies +secs_to_jiffies (C - * \( 1000 \| MSEC_PER_SEC \) ) Can any expressions become relevant besides =E2=80=9Cconstants=E2=80=9D? Regards, Markus