From: "Das, Nirmoy" <nirmoy.das@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, intel-xe@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-xe] [PATCH] drm/xe: fix kernel-doc issues
Date: Mon, 22 May 2023 13:07:37 +0200 [thread overview]
Message-ID: <90a44499-610f-1efc-9154-855bd22aed73@linux.intel.com> (raw)
In-Reply-To: <20230522110133.25968-1-matthew.auld@intel.com>
On 5/22/2023 1:01 PM, Matthew Auld wrote:
> drivers/gpu/drm/xe/xe_guc_submit_types.h:47: warning: cannot understand
> function prototype: 'struct guc_submit_parallel_scratch '
>
> drivers/gpu/drm/xe/xe_devcoredump_types.h:38: warning: Function
> parameter or member 'ct' not described in 'xe_devcoredump_snapshot'
>
> CI doesn't appear to be running BAT anymore, assuming this is caused by
> the CI.Hooks now failing due to above warnings.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/xe/xe_devcoredump_types.h | 2 +-
> drivers/gpu/drm/xe/xe_guc_submit_types.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_devcoredump_types.h b/drivers/gpu/drm/xe/xe_devcoredump_types.h
> index 350b905d1797..c0d711eb6ab3 100644
> --- a/drivers/gpu/drm/xe/xe_devcoredump_types.h
> +++ b/drivers/gpu/drm/xe/xe_devcoredump_types.h
> @@ -27,7 +27,7 @@ struct xe_devcoredump_snapshot {
> ktime_t boot_time;
>
> /* GuC snapshots */
> - /** @ct_snapshot: GuC CT snapshot */
> + /** @ct: GuC CT snapshot */
> struct xe_guc_ct_snapshot *ct;
> /** @ge: Guc Engine snapshot */
> struct xe_guc_submit_engine_snapshot *ge;
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit_types.h b/drivers/gpu/drm/xe/xe_guc_submit_types.h
> index 88e855dae056..6765b2c6eab1 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit_types.h
> +++ b/drivers/gpu/drm/xe/xe_guc_submit_types.h
> @@ -41,7 +41,7 @@ struct sync_semaphore {
> };
>
> /**
> - * Struct guc_submit_parallel_scratch - A scratch shared mapped buffer.
> + * struct guc_submit_parallel_scratch - A scratch shared mapped buffer.
> */
> struct guc_submit_parallel_scratch {
> /** @wq_desc: Guc scheduler workqueue descriptor */
next prev parent reply other threads:[~2023-05-22 11:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 11:01 [Intel-xe] [PATCH] drm/xe: fix kernel-doc issues Matthew Auld
2023-05-22 11:03 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-05-22 11:05 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-05-22 11:07 ` Das, Nirmoy [this message]
2023-05-22 11:39 ` [Intel-xe] [PATCH] " Matthew Auld
2023-05-22 14:07 ` Rodrigo Vivi
2023-05-22 11:09 ` [Intel-xe] ✓ CI.Build: success for " Patchwork
2023-05-22 11:38 ` [Intel-xe] ○ CI.BAT: info " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90a44499-610f-1efc-9154-855bd22aed73@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox