From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Harrison, John C" <john.c.harrison@intel.com>,
"Brost, Matthew" <matthew.brost@intel.com>,
"Dong, Zhanjun" <zhanjun.dong@intel.com>,
"Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v7 5/6] drm/xe/xe_hw_engine: Update xe_hw_engine capture for debugfs/gt_reset
Date: Tue, 11 Feb 2025 17:34:00 +0000 [thread overview]
Message-ID: <917819dcd25fabc9732fbf151b1cc4e4b1f0bb30.camel@intel.com> (raw)
In-Reply-To: <20250210233254.419587-6-alan.previn.teres.alexis@intel.com>
On Mon, 2025-02-10 at 15:32 -0800, Teres Alexis, Alan Previn wrote:
> xe_hw_engine_print is called by debugfs to do an immediate raw
> --- a/drivers/gpu/drm/xe/xe_guc_capture_snapshot_types.h
> +++ b/drivers/gpu/drm/xe/xe_guc_capture_snapshot_types.h
> @@ -12,7 +12,11 @@
> struct guc_mmio_reg;
>
> enum xe_guc_capture_snapshot_source {
> - XE_ENGINE_CAPTURE_SOURCE_MANUAL,
> + /* KMD captured engine registers when job timeout is detected */
> + XE_ENGINE_CAPTURE_SOURCE_MANUAL_JOB,
> + /* KMD captured raw engine registers without any job association */
> + XE_ENGINE_CAPTURE_SOURCE_MANUAL_RAW,
> + /* GUC-FW captured engine registers before workload was killed */
> XE_ENGINE_CAPTURE_SOURCE_GUC
> };
>
alan: some offline feedback was given to rename the enum to match:
"enum xe_guc_capture_snapshot_source" -> "enum xe_engine_capture_source"
next prev parent reply other threads:[~2025-02-11 17:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 23:32 [PATCH v7 0/6] Maintenence of devcoredump <-> GuC-Err-Capture plumbing Alan Previn
2025-02-10 23:32 ` [PATCH v7 1/6] drm/xe/guc: Rename __guc_capture_parsed_output Alan Previn
2025-02-10 23:32 ` [PATCH v7 2/6] drm/xe/guc: Don't store capture nodes in xe_devcoredump_snapshot Alan Previn
2025-02-10 23:32 ` [PATCH v7 3/6] drm/xe/guc: Split engine state print between xe_hw_engine vs xe_guc_capture Alan Previn
2025-02-11 22:48 ` Dong, Zhanjun
2025-02-12 18:50 ` Teres Alexis, Alan Previn
2025-02-10 23:32 ` [PATCH v7 4/6] drm/xe/guc: Move xe_hw_engine_snapshot creation back to xe_hw_engine.c Alan Previn
2025-02-12 17:19 ` Dong, Zhanjun
2025-02-10 23:32 ` [PATCH v7 5/6] drm/xe/xe_hw_engine: Update xe_hw_engine capture for debugfs/gt_reset Alan Previn
2025-02-11 17:34 ` Teres Alexis, Alan Previn [this message]
2025-02-12 18:24 ` Dong, Zhanjun
2025-02-10 23:32 ` [PATCH v7 6/6] drm/xe/guc: Update comments on GuC-Err-Capture flows Alan Previn
2025-02-11 23:09 ` Dong, Zhanjun
2025-02-12 18:54 ` Teres Alexis, Alan Previn
2025-02-11 0:38 ` ✓ CI.Patch_applied: success for Maintenence of devcoredump <-> GuC-Err-Capture plumbing Patchwork
2025-02-11 0:38 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-11 0:39 ` ✓ CI.KUnit: success " Patchwork
2025-02-11 0:56 ` ✓ CI.Build: " Patchwork
2025-02-11 0:57 ` ✗ CI.Hooks: failure " Patchwork
2025-02-11 0:58 ` ✗ CI.checksparse: warning " Patchwork
2025-02-11 1:18 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-11 13:01 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-13 0:56 ` Teres Alexis, Alan Previn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=917819dcd25fabc9732fbf151b1cc4e4b1f0bb30.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
--cc=matthew.brost@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=zhanjun.dong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox