Re: [PATCH] drm/xe: Add debug messages for MMU notifier and VMA invalidate

[Nirmoy Das <nirmoy.das@linux.intel.com>]

On 3/20/2024 8:42 PM, Matthew Brost wrote:
> Extra debug is useful when working on VM issues.
>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

  print_op() can be expanded to handle this but may be in a separate patch.

Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>

> ---
>   drivers/gpu/drm/xe/xe_vm.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 80d43d75b1da..e3692b7e1711 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -648,6 +648,10 @@ static bool vma_userptr_invalidate(struct mmu_interval_notifier *mni,
>   	if (!mmu_notifier_range_blockable(range))
>   		return false;
>   
> +	vm_dbg(&xe_vma_vm(vma)->xe->drm,
> +	       "NOTIFIER: addr=0x%016llx, range=0x%016llx",
> +		xe_vma_start(vma), xe_vma_size(vma));
> +
>   	down_write(&vm->userptr.notifier_lock);
>   	mmu_interval_set_seq(mni, cur_seq);
>   
> @@ -3233,6 +3237,10 @@ int xe_vm_invalidate_vma(struct xe_vma *vma)
>   	xe_assert(xe, !xe_vma_is_null(vma));
>   	trace_xe_vma_invalidate(vma);
>   
> +	vm_dbg(&xe_vma_vm(vma)->xe->drm,
> +	       "INVALIDATE: addr=0x%016llx, range=0x%016llx",
> +		xe_vma_start(vma), xe_vma_size(vma));
> +
>   	/* Check that we don't race with page-table updates */
>   	if (IS_ENABLED(CONFIG_PROVE_LOCKING)) {
>   		if (xe_vma_is_userptr(vma)) {