Re: [PATCH 0/7] Update GuC ABI definitions

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 29.03.2024 17:14, Lucas De Marchi wrote:
> On Thu, Mar 28, 2024 at 07:31:40PM +0100, Michal Wajdeczko wrote:
>> In upcoming patches we will use additional messages in communication
>> with the GuC firmware. Add necessary definitions to our ABI header.
> 
> but it would be better if these additions were done when they are
> needed. We don't want to keep updating this with things that may not be
> needed at all (plans always change, ABI may change to fix bugs, etc)

fully understand that, but...

this ABI definitions reflects what current firmware already supports
and it is just complementary to what was already pushed in initial
driver drop without supporting code:
 - [1] GuC VGT Policy KLVs
 - [2] GuC VF Configuration KLVs

[1]
https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/xe/abi/guc_klvs_abi.h#L114

[2]
https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/xe/abi/guc_klvs_abi.h#L154

it will also help me lower my pile of pending patches, so maybe there is
a chance for a small exception ?

Michal

> 
> Lucas De Marchi
> 
>>
>> Michal Wajdeczko (7):
>>  drm/xe/guc: Add PF2GUC_UPDATE_VF_CFG to ABI
>>  drm/xe/guc: Add PF2GUC_UPDATE_VGT_POLICY to ABI
>>  drm/xe/guc: Add GUC2PF_ADVERSE_EVENT to ABI
>>  drm/xe/guc: Add VF2GUC_MATCH_VERSION to ABI
>>  drm/xe/guc: Add VF2GUC_VF_RESET to ABI
>>  drm/xe/guc: Add VF2GUC_QUERY_SINGLE_KLV to ABI
>>  drm/xe/guc: Add GLOBAL_CFG_GMD_ID KLV definition
>>
>> .../gpu/drm/xe/abi/guc_actions_sriov_abi.h    | 289 ++++++++++++++++++
>> drivers/gpu/drm/xe/abi/guc_klvs_abi.h         |  13 +
>> 2 files changed, 302 insertions(+)
>>
>> -- 
>> 2.43.0
>>