Re: [PATCH] drm/xe: Remove NULL check of lrc->bo in xe_lrc_snapshot_capture()

[Nirmoy Das <nirmoy.das@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]


On 8/16/2024 10:03 AM, apoorva.singh@intel.com wrote:
> From: Apoorva Singh<apoorva.singh@intel.com>
>
> - lrc->bo NULL check is not needed in xe_lrc_snapshot_capture() as
>    its already been taken care of in xe_lrc_init().

It should be rather "it is always initialized in xe_lrc_init() ". With that

Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>


>
> Signed-off-by: Apoorva Singh<apoorva.singh@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_lrc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
> index 974a9cd8c379..aec7db39c061 100644
> --- a/drivers/gpu/drm/xe/xe_lrc.c
> +++ b/drivers/gpu/drm/xe/xe_lrc.c
> @@ -1649,7 +1649,7 @@ struct xe_lrc_snapshot *xe_lrc_snapshot_capture(struct xe_lrc *lrc)
>   	if (!snapshot)
>   		return NULL;
>   
> -	if (lrc->bo && lrc->bo->vm)
> +	if (lrc->bo->vm)
>   		xe_vm_get(lrc->bo->vm);
>   
>   	snapshot->context_desc = xe_lrc_ggtt_addr(lrc);

[-- Attachment #2: Type: text/html, Size: 1924 bytes --]