Re: [PATCH v7 1/1] drm/xe/guc: Handle GuC local uncorrectable error notifications

[Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>]

On 7/6/2026 4:43 PM, Zhanjun Dong wrote:
> Add support for the GuC uncorrectable local error G2H notification and
> opt in to the feature when the submission ABI exposes it.
>
> When the notification targets a known exec queue, treat it like an
> engine reset request and route it through the existing timeout cleanup
> path. This keeps the queue teardown, pending job cancellation and error
> capture in one place instead of open-coding a parallel recovery flow.
>
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> ---
> Changes to previous version:
> v6: Updated unknown GuC id error message (Daniele)
>      Updated length check (Daniele)
> v5: Switch to opt-in by has_uncorrectable_error_reporting in gt structure
> v4: Optimized GT and silicon version check.
>      Remove wedged mode==2 handling, which is handled by other feature
> v3: Remove not used flag bit and timeout worker check (Daniele)
>      Remove wedged mode==2 check, which will be handled in separate patch(Daniele)
> v2: Opt in for Xe3p only, excluding media GTs on NovaLake-P which don't support the feature
>      Remove timeout bypass, which is outside the scope of this patch and can be added separately
> ---
<snip>
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 12416bfa3255..49c5cf764e70 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -9,6 +9,7 @@
>   #include <linux/bitmap.h>
>   #include <linux/circ_buf.h>
>   #include <linux/dma-fence-array.h>
> +#include <linux/workqueue.h>

When merging I noticed that this new include is no longer required in 
the latest rev, so I dropped it after confirming with Zhanjun and then 
pushed.

Daniele