Re: [PATCH v3 23/26] drm/i915/writeback: Initialize writeback encoder.

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 3/25/2026 4:37 PM, Suraj Kandpal wrote:
> Call the init function to initialize the writeback encoder
> only for ADLP.
> 

This should be the last patch of the series.

My take on the gen limit is that we should enable it for all the 
generations that (reliably)support it in HW. That is the only way it 
gets enough
testing and the implementation stabilizes.

Also the series is now mature enough to come out of RFC stage. That 
means a proper implementation exposing both the writeback transcoders, 
with commit completion properly hooked up with WD_WRITE_COMPLETE_INT 
(among other things).

> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_display.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 4cc3e0779e8a..b4cf7153b7c8 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -8030,6 +8030,9 @@ void intel_setup_outputs(struct intel_display *display)
>   		intel_dvo_init(display);
>   	}
>   
> +	if (DISPLAY_VER(display) == 13)
> +		intel_writeback_init(display);
> +
>   	for_each_intel_encoder(display->drm, encoder) {
>   		encoder->base.possible_crtcs =
>   			intel_encoder_possible_crtcs(encoder);