Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Julia Filipchuk <julia.filipchuk@intel.com>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v3 3/4] drm/xe/guc: Release GuC v70.29.2 for BMG
Date: Fri, 2 Aug 2024 11:24:51 -0700	[thread overview]
Message-ID: <95e92605-e070-4ca1-91c6-6790b91788f8@intel.com> (raw)
In-Reply-To: <20240801224241.3050352-4-julia.filipchuk@intel.com>

"Release" in the commit title is a bit of a misdirection, because this 
patch does not release any GuC, we just define it. Maybe just 
s/Release/Define/ ?
With that (or a similar reword):

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

On 8/1/2024 3:42 PM, Julia Filipchuk wrote:
> UAPI version 1.13.4
>
> Signed-off-by: Julia Filipchuk <julia.filipchuk@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_uc_fw.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
> index fe1b97d3d2a0..05a3c5b80b5b 100644
> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
> @@ -106,6 +106,7 @@ struct fw_blobs_by_type {
>   };
>   
>   #define XE_GUC_FIRMWARE_DEFS(fw_def, mmp_ver, major_ver)			\
> +	fw_def(BATTLEMAGE,	major_ver(xe,	guc,	bmg,	70, 29, 2))	\
>   	fw_def(LUNARLAKE,	major_ver(xe,	guc,	lnl,	70, 29, 2))	\
>   	fw_def(METEORLAKE,	major_ver(i915,	guc,	mtl,	70, 29, 2))	\
>   	fw_def(DG2,		major_ver(i915,	guc,	dg2,	70, 29, 2))	\


  reply	other threads:[~2024-08-02 18:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-01 22:42 [PATCH v3 0/4] Release GuC v70.29.2 as minimum for Xe (support LNL, BMG) Julia Filipchuk
2024-08-01 22:42 ` [PATCH v3 1/4] drm/xe/guc: Drop use of pre-release GuC definitions for LNL and BMG Julia Filipchuk
2024-08-02 18:08   ` Daniele Ceraolo Spurio
2024-08-01 22:42 ` [PATCH v3 2/4] drm/xe/guc: Release GuC v70.29.2 for Xe as minimum required version Julia Filipchuk
2024-08-02 18:22   ` Daniele Ceraolo Spurio
2024-08-01 22:42 ` [PATCH v3 3/4] drm/xe/guc: Release GuC v70.29.2 for BMG Julia Filipchuk
2024-08-02 18:24   ` Daniele Ceraolo Spurio [this message]
2024-08-01 22:42 ` [PATCH xe-for-ci v3 4/4] drm/xe/guc: Pick for-ci GuC v70.29.2 for PVC Julia Filipchuk
2024-08-01 23:26 ` ✓ CI.Patch_applied: success for Release GuC v70.29.2 as minimum for Xe (support LNL, BMG) Patchwork
2024-08-01 23:26 ` ✗ CI.checkpatch: warning " Patchwork
2024-08-01 23:27 ` ✓ CI.KUnit: success " Patchwork
2024-08-01 23:39 ` ✓ CI.Build: " Patchwork
2024-08-01 23:41 ` ✓ CI.Hooks: " Patchwork
2024-08-01 23:43 ` ✓ CI.checksparse: " Patchwork
2024-08-02  0:02 ` ✓ CI.BAT: " Patchwork
2024-08-02  2:54 ` ✓ CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95e92605-e070-4ca1-91c6-6790b91788f8@intel.com \
    --to=daniele.ceraolospurio@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=julia.filipchuk@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox