Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Auld <matthew.auld@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	intel-xe@lists.freedesktop.org
Cc: Matthew Brost <matthew.brost@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 2/2] drm/xe: Select CONFIG_DEVICE_PRIVATE when DRM_XE_GPUSVM is selected
Date: Wed, 21 Jan 2026 17:59:34 +0000	[thread overview]
Message-ID: <97681265-611b-4b5c-887d-579a3cc82258@intel.com> (raw)
In-Reply-To: <20260121091048.41371-3-thomas.hellstrom@linux.intel.com>

On 21/01/2026 09:10, Thomas Hellström wrote:
> CONFIG_DEVICE_PRIVATE is a prerequisite for DRM_XE_GPUSVM.
> Explicitly select it so that DRM_XE_GPUSVM is not unintentionally
> left out from distro configs not explicitly enabling
> CONFIG_DEVICE_PRIVATE.
> 
> v2:
> - Select also CONFIG_ZONE_DEVICE since it's needed by
>    CONFIG_DEVICE_PRIVATE.
> v3:
> - Depend on CONFIG_ZONE_DEVICE rather than selecting it.
> 
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: <dri-devel@lists.freedesktop.org>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

Reviewed-by: Matthew Auld <matthew.auld@intel.com>

> ---
>   drivers/gpu/drm/xe/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> index c34be1be155b..4d7dcaff2b91 100644
> --- a/drivers/gpu/drm/xe/Kconfig
> +++ b/drivers/gpu/drm/xe/Kconfig
> @@ -80,8 +80,9 @@ config DRM_XE_GPUSVM
>   	bool "Enable CPU to GPU address mirroring"
>   	depends on DRM_XE
>   	depends on !UML
> -	depends on DEVICE_PRIVATE
> +	depends on ZONE_DEVICE
>   	default y
> +	select DEVICE_PRIVATE
>   	select DRM_GPUSVM
>   	help
>   	  Enable this option if you want support for CPU to GPU address


  reply	other threads:[~2026-01-21 17:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21  9:10 [PATCH v3 0/2] drm, drm/xe: Fix xe SVM configs Thomas Hellström
2026-01-21  9:10 ` [PATCH v3 1/2] drm, drm/xe: Fix xe userptr in the absence of CONFIG_DEVICE_PRIVATE Thomas Hellström
2026-01-21 17:19   ` Matthew Auld
2026-01-21 17:25     ` Thomas Hellström
2026-01-21 17:54       ` Matthew Auld
2026-01-22  8:30   ` Maarten Lankhorst
2026-01-21  9:10 ` [PATCH v3 2/2] drm/xe: Select CONFIG_DEVICE_PRIVATE when DRM_XE_GPUSVM is selected Thomas Hellström
2026-01-21 17:59   ` Matthew Auld [this message]
2026-01-21  9:52 ` ✓ CI.KUnit: success for drm, drm/xe: Fix xe SVM configs (rev3) Patchwork
2026-01-21 10:38 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-21 15:07 ` ✓ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97681265-611b-4b5c-887d-579a3cc82258@intel.com \
    --to=matthew.auld@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox