From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DD02C54FB3 for ; Thu, 29 May 2025 21:41:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D5A2410E13A; Thu, 29 May 2025 21:41:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="mFQTaBHD"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6834A10E1A4 for ; Thu, 29 May 2025 21:41:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748554868; x=1780090868; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=yquT3Q4Y6eg+V6FFQsYXuCPYWA9Chl04Rh0ku0nJ8pY=; b=mFQTaBHDm+RtE+i/eOEcspzMkdvY8Fex1Nvt2egUtbrCqjh1dY/LLwDy OFNkgLLXgOsSYNjhx7B7Fsow9v9afPb0PqCLYf/Le0UMzWWspkhg1oTiZ JofdKyC2AMk7g6MGQboNU13FN/7PClBFe+nSNYBablgq4Oi+OKfvDTOph LdMHVoLdviND1qNUMYEWfPHxI7E2puQdNc5fHRnTUmN/Q/9CwHkms/+7B P81BPrRPlYgS1z6Wp10zlB+zQoZ1H3QK3Nw80AX2gUhickgKiWsc8Qu9C SH1oGyYm6SZNmbGTAfwZuHg+J5kcY2NU8H9sC79IU/hRH+jWv7JgbmeaA A==; X-CSE-ConnectionGUID: RlcBi7r0QledJ9ToQHuYEg== X-CSE-MsgGUID: lty7Cb7YQLiKMc0irljHMg== X-IronPort-AV: E=McAfee;i="6700,10204,11448"; a="50522142" X-IronPort-AV: E=Sophos;i="6.16,194,1744095600"; d="scan'208";a="50522142" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2025 14:41:03 -0700 X-CSE-ConnectionGUID: 5MEdQjDERmmsOI2lYMSOZQ== X-CSE-MsgGUID: RA+F4muaQNKdTjJTYvCpvw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,194,1744095600"; d="scan'208";a="143638735" Received: from linux.intel.com ([10.54.29.200]) by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2025 14:41:03 -0700 Received: from [10.124.222.225] (unknown [10.124.222.225]) by linux.intel.com (Postfix) with ESMTP id D020A20B5736; Thu, 29 May 2025 14:41:01 -0700 (PDT) Message-ID: <98fc8402-0bda-4333-8407-75c7a6472375@linux.intel.com> Date: Thu, 29 May 2025 14:41:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 02/11] PCI/ACPI: Per root port allow one Aux power limit request To: Badal Nilawar , intel-xe@lists.freedesktop.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org Cc: anshuman.gupta@intel.com, rafael@kernel.org, lenb@kernel.org, bhelgaas@google.com, ilpo.jarvinen@linux.intel.com, lucas.demarchi@intel.com, rodrigo.vivi@intel.com, varun.gupta@intel.com, ville.syrjala@linux.intel.com, uma.shankar@intel.com References: <20250529111654.3140766-1-badal.nilawar@intel.com> <20250529111654.3140766-3-badal.nilawar@intel.com> Content-Language: en-US From: Sathyanarayanan Kuppuswamy In-Reply-To: <20250529111654.3140766-3-badal.nilawar@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 5/29/25 4:16 AM, Badal Nilawar wrote: > For given root port allow one Aux power limit request. > > Cc: Rafael J. Wysocki > Cc: Anshuman Gupta > Signed-off-by: Badal Nilawar > --- > drivers/acpi/scan.c | 1 + > drivers/pci/pci-acpi.c | 25 ++++++++++++++++++++++++- > include/acpi/acpi_bus.h | 2 ++ > 3 files changed, 27 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index fb1fe9f3b1a3..9ae7be9db01a 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -745,6 +745,7 @@ int acpi_device_add(struct acpi_device *device) > INIT_LIST_HEAD(&device->physical_node_list); > INIT_LIST_HEAD(&device->del_list); > mutex_init(&device->physical_node_lock); > + mutex_init(&device->power.aux_pwr_lock); > > mutex_lock(&acpi_device_lock); > > diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c > index 87f30910a5f1..d33efba4ca94 100644 > --- a/drivers/pci/pci-acpi.c > +++ b/drivers/pci/pci-acpi.c > @@ -1451,6 +1451,7 @@ int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power, > union acpi_object *out_obj; > acpi_handle handle; > int result, ret = -EINVAL; > + struct acpi_device *adev; > > if (!dev || !retry_interval) > return -EINVAL; > @@ -1464,11 +1465,27 @@ int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power, > return -ENODEV; > } > > + adev = ACPI_COMPANION(&dev->dev); > + if (!adev) > + return -EINVAL; > + > + mutex_lock(&adev->power.aux_pwr_lock); > + > + /* Check if aux power already granted */ > + if (adev->power.aux_power_limit) { > + pci_info(dev, "D3cold Aux Power request already granted: %u mW\n", > + adev->power.aux_power_limit); > + mutex_unlock(&adev->power.aux_pwr_lock); > + return -EPERM; > + } > + > out_obj = acpi_evaluate_dsm_typed(handle, &pci_acpi_dsm_guid, 4, > DSM_PCI_D3COLD_AUX_POWER_LIMIT, > &in_obj, ACPI_TYPE_INTEGER); > - if (!out_obj) > + if (!out_obj) { > + mutex_unlock(&adev->power.aux_pwr_lock); > return -EINVAL; > + } > > result = out_obj->integer.value; > if (retry_interval) > @@ -1478,14 +1495,17 @@ int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power, > case 0x0: > pci_dbg(dev, "D3cold Aux Power %u mW request denied\n", > requested_power); > + adev->power.aux_power_limit = 0; > break; > case 0x1: > pci_info(dev, "D3cold Aux Power request granted: %u mW\n", > requested_power); > + adev->power.aux_power_limit = requested_power; > ret = 0; > break; > case 0x2: > pci_info(dev, "D3cold Aux Power: Main power won't be removed\n"); > + adev->power.aux_power_limit = 0; > ret = -EBUSY; > break; > default: > @@ -1500,9 +1520,12 @@ int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power, > pci_err(dev, "D3cold Aux Power: Reserved or unsupported response: 0x%x\n", > result); > } > + adev->power.aux_power_limit = 0; > break; > } > > + mutex_unlock(&adev->power.aux_pwr_lock); > + > ACPI_FREE(out_obj); > return ret; > } > diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h > index aad1a95e6863..c4ce3d84be00 100644 > --- a/include/acpi/acpi_bus.h > +++ b/include/acpi/acpi_bus.h > @@ -294,6 +294,8 @@ struct acpi_device_power { > struct acpi_device_power_flags flags; > struct acpi_device_power_state states[ACPI_D_STATE_COUNT]; /* Power states (D0-D3Cold) */ > u8 state_for_enumeration; /* Deepest power state for enumeration */ > + u32 aux_power_limit; /* aux power limit granted by bios */ > + struct mutex aux_pwr_lock; /* prevent concurrent aux power limit requests */ Do you need a new lock ? Is it possible to reuse existing mutex like device_lock()? > }; > > struct acpi_dep_data { -- Sathyanarayanan Kuppuswamy Linux Kernel Developer