From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: Shuicheng Lin <shuicheng.lin@intel.com>,
<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 2/3] drm/xe: Fix kerneldoc for xe_gt_tlb_inval_init_early
Date: Fri, 30 Jan 2026 00:26:58 +0100 [thread overview]
Message-ID: <994d6230-ca33-447c-ac76-daad130bc1af@intel.com> (raw)
In-Reply-To: <20260129225606.412902-7-shuicheng.lin@intel.com>
On 1/29/2026 11:56 PM, Shuicheng Lin wrote:
> Correct the function name in the kerneldoc.
> It is for below warning:
> "Warning: drivers/gpu/drm/xe/xe_tlb_inval.c:136 expecting prototype for
> xe_gt_tlb_inval_init(). Prototype was for xe_gt_tlb_inval_init_early() instead"
>
> Fixes: db16f9d90c1d9 ("drm/xe: Split TLB invalidation code in frontend and backend")
> Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
> ---> drivers/gpu/drm/xe/xe_tlb_inval.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_tlb_inval.c b/drivers/gpu/drm/xe/xe_tlb_inval.c
> index 989fe0e7f8ee..2ea1b1708700 100644
> --- a/drivers/gpu/drm/xe/xe_tlb_inval.c
> +++ b/drivers/gpu/drm/xe/xe_tlb_inval.c
> @@ -125,7 +125,7 @@ static void primelockdep(struct xe_tlb_inval *tlb_inval)
> }
>
> /**
> - * xe_gt_tlb_inval_init - Initialize TLB invalidation state
> + * xe_gt_tlb_inval_init_early - Initialize TLB invalidation state
maybe while here, use the preferred notation:
* xe_gt_tlb_inval_init_early() - Initialize TLB invalidation state
> * @gt: GT structure
> *
> * Initialize TLB invalidation state, purely software initialization, should
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
next prev parent reply other threads:[~2026-01-29 23:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 22:56 [PATCH 0/3] Fix warning of kerneldoc Shuicheng Lin
2026-01-29 22:56 ` [PATCH 1/3] drm/xe: Fix kerneldoc for xe_migrate_exec_queue Shuicheng Lin
2026-01-29 23:22 ` Michal Wajdeczko
2026-01-29 22:56 ` [PATCH 2/3] drm/xe: Fix kerneldoc for xe_gt_tlb_inval_init_early Shuicheng Lin
2026-01-29 23:26 ` Michal Wajdeczko [this message]
2026-01-29 22:56 ` [PATCH 3/3] drm/xe: Fix kerneldoc for xe_tlb_inval_job_alloc_dep Shuicheng Lin
2026-01-29 23:29 ` Michal Wajdeczko
2026-01-29 23:06 ` ✗ CI.checkpatch: warning for Fix warning of kerneldoc Patchwork
2026-01-29 23:07 ` ✓ CI.KUnit: success " Patchwork
2026-01-29 23:47 ` ✓ Xe.CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=994d6230-ca33-447c-ac76-daad130bc1af@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=shuicheng.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox