From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>, <arun.r.murthy@intel.com>,
<intel-xe@lists.freedesktop.org>, <jani.nikula@intel.com>
Subject: Re: [PATCH v3] i915/display/dp: Compute AS SDP when vrr is also enabled
Date: Tue, 30 Jul 2024 17:14:54 +0530 [thread overview]
Message-ID: <9973e91f-e6ca-49b7-b8bc-06bf20603377@intel.com> (raw)
In-Reply-To: <20240730040941.396862-1-mitulkumar.ajitkumar.golani@intel.com>
On 7/30/2024 9:39 AM, Mitul Golani wrote:
> AS SDP should be computed when VRR timing generator is also enabled.
> Correct the compute condition to compute params of Adaptive sync SDP
> when VRR timing genrator is enabled along with sink support indication.
>
> --v2:
> Modify if condition (Jani).
>
> Fixes: b2013783c445 ("drm/i915/display: Cache adpative sync caps to use it later")
> Cc: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> Cc: Arun R Murthy <arun.r.murthy@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Cc: intel-xe@lists.freedesktop.org
> Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Thanks for the patch. Added prefix drm to the subject and pushed to
drm-intel-next.
Regards,
Ankit
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 5d6568c8e186..86412ae7b48f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2617,7 +2617,7 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp,
> const struct drm_display_mode *adjusted_mode =
> &crtc_state->hw.adjusted_mode;
>
> - if (!crtc_state->vrr.enable || intel_dp->as_sdp_supported)
> + if (!crtc_state->vrr.enable || !intel_dp->as_sdp_supported)
> return;
>
> crtc_state->infoframes.enable |= intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC);
prev parent reply other threads:[~2024-07-30 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240726085012.277687-1-mitulkumar.ajitkumar.golani@intel.com>
2024-07-30 4:09 ` [PATCH v3] i915/display/dp: Compute AS SDP when vrr is also enabled Mitul Golani
2024-07-30 11:44 ` Nautiyal, Ankit K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9973e91f-e6ca-49b7-b8bc-06bf20603377@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=mitulkumar.ajitkumar.golani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox