Re: [PATCH v3 0/4] drm: replace drm_print.h includes from headers with a forward declaration

[Thomas Zimmermann <tzimmermann@suse.de>]

Hi

Am 31.10.25 um 11:01 schrieb Jani Nikula:
> On Thu, 30 Oct 2025, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>> Am 30.10.25 um 10:31 schrieb Jani Nikula:
>>> Considering that this touches a lot of drivers, albeit just the include
>>> lists and thus highly unlikely to cause functional changes or hard
>>> conflicts, can I go ahead and merge this to drm-misc-next?
>> Of course, go ahead.
> Done, thanks again!

Looks like fallout from this series:


   CC [M]  drivers/gpu/drm/rockchip/rockchip_drm_vop2.o
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 
'vop2_convert_format':
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:215:17: error: 
implicit declaration of function 'DRM_ERROR'; did you mean 'SO_ERROR'? 
[-Wimplicit-function-declaration]
   215 |                 DRM_ERROR("unsupported format[%08x]\n", format);
       |                 ^~~~~~~~~
       |                 SO_ERROR
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 
'rockchip_vop2_mod_supported':
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:395:33: error: 
implicit declaration of function 'drm_dbg_kms' 
[-Wimplicit-function-declaration]
   395 |                                 drm_dbg_kms(vop2->drm,
       |                                 ^~~~~~~~~~~
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 
'vop2_setup_scale':
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:602:25: error: 
implicit declaration of function 'drm_dbg'; did you mean 'dev_dbg'? 
[-Wimplicit-function-declaration]
   602 |                         drm_dbg(vop2->drm, "%s dst_w[%d] should 
align as 2 pixel\n",
       |                         ^~~~~~~
       |                         dev_dbg
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 
'vop2_core_clks_prepare_enable':
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:763:17: error: 
implicit declaration of function 'drm_err'; did you mean 'pr_err'? 
[-Wimplicit-function-declaration]
   763 |                 drm_err(vop2->drm, "failed to enable hclk - 
%d\n", ret);
       |                 ^~~~~~~
       |                 pr_err
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 
'vop2_crtc_atomic_disable':
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:967:17: error: 
implicit declaration of function 'drm_info'; did you mean 'pr_info'? 
[-Wimplicit-function-declaration]
   967 |                 drm_info(vop2->drm, "wait for vp%d dsp_hold 
timeout\n", vp->id);
       |                 ^~~~~~~~
       |                 pr_info
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 
'vop2_crtc_atomic_enable':
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:1758:41: error: 
implicit declaration of function 'drm_warn'; did you mean 'dev_warn'? 
[-Wimplicit-function-declaration]
  1758 |  drm_warn(vop2->drm,
       |                                         ^~~~~~~~
       |                                         dev_warn
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c: In function 
'rk3576_vp_isr':
linux/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:2198:17: error: 
implicit declaration of function 'drm_err_ratelimited'; did you mean 
'pr_err_ratelimited'? [-Wimplicit-function-declaration]
  2198 |                 drm_err_ratelimited(vop2->drm, "POST_BUF_EMPTY 
irq err at vp%d\n", vp->id);
       |                 ^~~~~~~~~~~~~~~~~~~
       |                 pr_err_ratelimited


Best regards
Thomas

>
> BR,
> Jani.
>
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)