Re: [PATCH] drm/xe: Don't emit UTS_RELEASE as part of device coredump

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 27 Apr 2026, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Mon, Apr 27, 2026 at 06:09:03PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
>> UTS_RELEASE changes quite easily (e.g. uncommitted changes in the source
>
> we know, this is exactly why we use it ;)
> We want to be able to differentiate if it is a distro build versus custom build.
>
>> tree or new commits). So when checking if a patch introduces changes to the
>> resulting binary each usage of UTS_RELEASE is a source of annoyance as
>> it introduces changes not caused by the change under test.

Would it help to use init_uts_ns.name.release from
init/version-timestamp.c instead of UTS_RELEASE? No rebuilds, info
retained.

BR,
Jani.



>> 
>> It's little helpful to emit the kernel version in the device coredump, so
>> drop the kernel version line from it.
>
> That's a driver decision, no?!
> We think it is useful and this change breaks the tools that are parsing it.
> So, please drop this patch.
>
> Thanks,
> Rodrigo.
>
>> 
>> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
>> ---
>> Hello,
>> 
>> I'm not really sure if my assertion above that the kernel version isn't
>> helpful is actually true.
>> 
>> If yes, there are a few more very similar changes to make:
>> 
>> 	$ git grep -E 'drm_p.*UTS_RELEASE' v7.1-rc1 drivers/gpu/
>> 	v7.1-rc1:drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c:      drm_printf(&p, "kernel: " UTS_RELEASE "\n");
>> 	v7.1-rc1:drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c:     drm_printf(p, "kernel: " UTS_RELEASE "\n");
>> 	v7.1-rc1:drivers/gpu/drm/msm/msm_gpu.c: drm_printf(&p, "kernel: " UTS_RELEASE "\n");
>> 	v7.1-rc1:drivers/gpu/drm/xe/xe_devcoredump.c:   drm_puts(&p, "kernel: " UTS_RELEASE "\n");
>> 
>> Best regards
>> Uwe
>> 
>>  drivers/gpu/drm/xe/xe_devcoredump.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
>> index 558a1a9841a0..260e3f19286b 100644
>> --- a/drivers/gpu/drm/xe/xe_devcoredump.c
>> +++ b/drivers/gpu/drm/xe/xe_devcoredump.c
>> @@ -101,7 +101,6 @@ static ssize_t __xe_devcoredump_read(char *buffer, ssize_t count,
>>  
>>  	drm_puts(&p, "**** Xe Device Coredump ****\n");
>>  	drm_printf(&p, "Reason: %s\n", ss->reason);
>> -	drm_puts(&p, "kernel: " UTS_RELEASE "\n");
>>  	drm_puts(&p, "module: " KBUILD_MODNAME "\n");
>>  
>>  	ts = ktime_to_timespec64(ss->snapshot_time);
>> 
>> base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
>> -- 
>> 2.47.3
>> 

-- 
Jani Nikula, Intel