Re: [PATCH] drm/xe: Prefer USEC_PER_SEC over MICRO

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 11-03-2025 19:31, Michal Wajdeczko wrote:
> It will be easier to understand the meaning of the flr_timeout
> value if the USEC_PER_SEC macro is used in the expression.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_device.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 5d79b439dd62..7d32d5c6538f 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -522,7 +522,7 @@ static bool xe_driver_flr_disabled(struct xe_device *xe)
>    */
>   static void __xe_driver_flr(struct xe_device *xe)
>   {
> -	const unsigned int flr_timeout = 3 * MICRO; /* specs recommend a 3s wait */
> +	const unsigned int flr_timeout = 3 * USEC_PER_SEC; /* specs recommend a 3s wait */

Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

>   	struct xe_mmio *mmio = xe_root_tile_mmio(xe);
>   	int ret;
>