Re: [PATCH v2] drm/xe/throttle: Log throttle reasons

[Riana Tauro <riana.tauro@intel.com>]

On 11/29/2024 1:13 PM, Raag Jadav wrote:
> Log throttle register MMIO reads which will be useful for debugging.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Looks good to me
Reviewed-by: Riana Tauro <riana.tauro@intel.com>

> ---
> 
> v2: Use gt oriented logging (Michal)
>      Drop local variables (Ashutosh, Rodrigo)
>      Move logging to status attribute and reduce spam (Matthew Brost)
> 
>   drivers/gpu/drm/xe/xe_gt_throttle.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_throttle.c b/drivers/gpu/drm/xe/xe_gt_throttle.c
> index 03b225364101..8db78d616b6f 100644
> --- a/drivers/gpu/drm/xe/xe_gt_throttle.c
> +++ b/drivers/gpu/drm/xe/xe_gt_throttle.c
> @@ -8,6 +8,7 @@
>   #include <regs/xe_gt_regs.h>
>   #include "xe_device.h"
>   #include "xe_gt.h"
> +#include "xe_gt_printk.h"
>   #include "xe_gt_sysfs.h"
>   #include "xe_gt_throttle.h"
>   #include "xe_mmio.h"
> @@ -53,6 +54,7 @@ static u32 read_status(struct xe_gt *gt)
>   {
>   	u32 status = xe_gt_throttle_get_limit_reasons(gt) & GT0_PERF_LIMIT_REASONS_MASK;
>   
> +	xe_gt_dbg(gt, "throttle reasons: 0x%08x\n", status);
>   	return status;
>   }
>