From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8124C87FD2 for ; Tue, 5 Aug 2025 10:10:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D29B10E00D; Tue, 5 Aug 2025 10:10:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="b8jWIwV3"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAD9810E00D; Tue, 5 Aug 2025 10:10:15 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 401A45C1858; Tue, 5 Aug 2025 10:10:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E900AC4CEF0; Tue, 5 Aug 2025 10:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754388614; bh=7pQk1iFFbNlUBBZjYXpLBBqP7Ym383++EsWDKlWE6qw=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=b8jWIwV3WICqjBWlvKJXq5UsQrBhXWR6ZHfJ44PdkkEgBX5cMaEv1koofnrINGUUb 3JbFQm0324CeOEC4DtmyPEVdZihm30DCd+s3mDH5VqYi+Udy6G6IrSpGKDnheU9lyk qGOUXtdAxw0PB1m9LeAGgB/vYTK7KE+3UW0NwfS+9ubk/NIk3T851lZ2iK2qdyFxeX niaY1qr9yxszzni05TBPERLKUTVFm3nifIHoJtbkmajPtmoVdlpAJ/HEjkLfC0PGGE vejn+kYWPIXo280ItRWt1jNlThpLsW0fuRefyf/DmjR13VMqtvminNow6m4xsyHbqT Zc9u77Oz5XC2w== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 05 Aug 2025 12:10:11 +0200 Message-Id: Subject: Re: [PATCH v5 01/25] drm/gpuvm: Pass map arguments through a struct Cc: "Matthew Brost" , , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , "Boris Brezillon" , "Danilo Krummrich" , "Boris Brezillon" , "Caterina Shablia" , "Rob Clark" , To: "Ghimiray, Himal Prasad" From: "Danilo Krummrich" References: <20250730130050.1001648-1-himal.prasad.ghimiray@intel.com> <20250730130050.1001648-2-himal.prasad.ghimiray@intel.com> In-Reply-To: X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue Aug 5, 2025 at 7:24 AM CEST, Himal Prasad Ghimiray wrote: > On 05-08-2025 09:26, Matthew Brost wrote: >> Also I believe Danilo's suggestion here was to define drm_gpuvm_map_req >> as the argument and then embed drm_gpuva_op_map within >> drm_gpuvm_map_req. So in patch [1], flags would be added to >> drm_gpuvm_map_req rather than drm_gpuva_op_map. >>=20 >> Matt >>=20 >> [1] https://patchwork.freedesktop.org/patch/666211/?series=3D149550&rev= =3D5 > > Hi Matt, > > Thanks for the review. Initially, I considered using drm_gpuvm_map_req=20 > struct instead of passing drm_gpuva_op_map directly to the gpuvm layer,= =20 > allowing it to handle split/merge decisions independently. Generally, we should only have the flags field on struct drm_gpuva_op_map i= f we need to let GPUVM pass flags for (re)map operations to drivers. > However, the upcoming patch [1] relies on this flag to determine=20 > driver-side behavior. So at the end drm_gpuva_op_map and=20 > drm_gpuvm_map_req might end up identical. Based on that=E2=80=94and Danil= o=E2=80=99s=20 > feedback on this patch [2] I thought It will be better to keep a single= =20 > op_map struct with the flag included. Let's leave this to the upcoming patches, we can always adjust. For now, le= t's go with what Matt summarized above please. > Boris, could you please confirm if the flag will be useful on the driver= =20 > side [1]? > > [1] https://patchwork.freedesktop.org/patch/662832/?series=3D151264&rev= =3D2 > [2] https://patchwork.freedesktop.org/patch/662819/?series=3D151264&rev= =3D2