From: "Danilo Krummrich" <dakr@kernel.org>
To: "Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>
Cc: dri-devel@lists.freedesktop.org, kernel-dev@igalia.com,
intel-xe@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Philipp Stanner" <phasta@kernel.org>
Subject: Re: [PATCH] drm/sched: Simplify idle entity check
Date: Wed, 07 Jan 2026 15:08:06 +0100 [thread overview]
Message-ID: <DFIEZJJK8GUD.1XW0UQSIUCH2N@kernel.org> (raw)
In-Reply-To: <20260107134405.96603-1-tvrtko.ursulin@igalia.com>
On Wed Jan 7, 2026 at 2:44 PM CET, Tvrtko Ursulin wrote:
> While at it, we add READ_ONCE annotation on the entity->stopped check to
> mark the unlocked read.
READ_ONCE() is not about marking unlocked reads and does not guarantee
atomicity.
Instead, it is about compiler control, i.e. forcing loads, and, depending on the
architecture, deal with address and control dependency barriers.
If we want lockless access to entity->stopped it should be atomic_read(),
atomic_read_acquire(), etc.
- Danilo
next prev parent reply other threads:[~2026-01-07 14:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 13:44 [PATCH] drm/sched: Simplify idle entity check Tvrtko Ursulin
2026-01-07 13:50 ` ✗ CI.checkpatch: warning for " Patchwork
2026-01-07 13:51 ` ✓ CI.KUnit: success " Patchwork
2026-01-07 14:08 ` Danilo Krummrich [this message]
2026-01-09 14:08 ` [PATCH] " Danilo Krummrich
2026-01-07 14:11 ` Philipp Stanner
2026-01-09 14:06 ` Tvrtko Ursulin
2026-01-09 14:31 ` Christian König
2026-01-15 13:30 ` Tvrtko Ursulin
2026-01-09 14:48 ` Philipp Stanner
2026-01-09 15:11 ` Christian König
2026-01-12 10:35 ` Tvrtko Ursulin
2026-01-07 14:29 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-01-07 16:32 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFIEZJJK8GUD.1XW0UQSIUCH2N@kernel.org \
--to=dakr@kernel.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=kernel-dev@igalia.com \
--cc=matthew.brost@intel.com \
--cc=phasta@kernel.org \
--cc=tvrtko.ursulin@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox