public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Koen Koning" <koen.koning@linux.intel.com>
Cc: <dri-devel@lists.freedesktop.org>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Dave Airlie" <airlied@redhat.com>,
	<intel-xe@lists.freedesktop.org>,
	"Peter Senna Tschudin" <peter.senna@linux.intel.com>,
	"dri-devel" <dri-devel-bounces@lists.freedesktop.org>,
	"Matthew Auld" <matthew.auld@intel.com>,
	"Arun Pravin" <arunpravin.paneerselvam@amd.com>
Subject: Re: [PATCH] gpu: Fix uninitialized buddy for built-in drivers
Date: Mon, 23 Feb 2026 23:30:42 +0100	[thread overview]
Message-ID: <DGMP3YT8VSCW.3OJRL3TK5PLRQ@kernel.org> (raw)
In-Reply-To: <20260213152047.179628-1-koen.koning@linux.intel.com>

(Cc: Matthew, Arun)

On Fri Feb 13, 2026 at 4:20 PM CET, Koen Koning wrote:
> Move buddy to the start of the link order, so its __init runs before any
> other built-in drivers that may depend on it. Otherwise, a built-in
> driver that tries to use the buddy allocator will run into a kernel NULL
> pointer dereference because slab_blocks is uninitialized.
>
> Specifically, this fixes drm/xe (as built-in) running into a kernel
> panic during boot, because it uses buddy during device probe.
>
> Fixes: ba110db8e1bc ("gpu: Move DRM buddy allocator one level up (part two)")
> Cc: Joel Fernandes <joelagnelf@nvidia.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: intel-xe@lists.freedesktop.org
> Tested-by: Peter Senna Tschudin <peter.senna@linux.intel.com>
> Signed-off-by: Koen Koning <koen.koning@linux.intel.com>
> ---
>  drivers/gpu/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/Makefile b/drivers/gpu/Makefile
> index 5cd54d06e262..b4e5e338efa2 100644
> --- a/drivers/gpu/Makefile
> +++ b/drivers/gpu/Makefile
> @@ -2,8 +2,9 @@
>  # drm/tegra depends on host1x, so if both drivers are built-in care must be
>  # taken to initialize them in the correct order. Link order is the only way
>  # to ensure this currently.
> +# Similarly, buddy must come first since it is used by other drivers.
> +obj-$(CONFIG_GPU_BUDDY)	+= buddy.o
>  obj-y			+= host1x/ drm/ vga/ tests/
>  obj-$(CONFIG_IMX_IPUV3_CORE)	+= ipu-v3/
>  obj-$(CONFIG_TRACE_GPU_MEM)		+= trace/
>  obj-$(CONFIG_NOVA_CORE)		+= nova-core/
> -obj-$(CONFIG_GPU_BUDDY)		+= buddy.o
> -- 
> 2.48.1


      parent reply	other threads:[~2026-02-23 22:30 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 15:20 [PATCH] gpu: Fix uninitialized buddy for built-in drivers Koen Koning
2026-02-13 15:29 ` ✓ CI.KUnit: success for " Patchwork
2026-02-13 16:04 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-13 17:27 ` [PATCH] " Joel Fernandes
2026-02-16 10:28   ` Matthew Auld
2026-02-14 13:43 ` ✓ Xe.CI.FULL: success for " Patchwork
2026-02-16 11:19 ` [PATCH v2] " Koen Koning
2026-02-16 21:31   ` Joel Fernandes
2026-02-19 10:16   ` Danilo Krummrich
2026-02-19 10:38     ` Matthew Auld
2026-02-19 11:14       ` Danilo Krummrich
2026-02-19 12:44         ` Matthew Auld
2026-02-19 12:56           ` Danilo Krummrich
2026-02-19 15:32             ` Matthew Auld
2026-02-19 16:08               ` Danilo Krummrich
2026-02-19 18:28             ` Koen Koning
2026-02-19 18:34               ` Danilo Krummrich
2026-02-19 21:38   ` [PATCH v3 0/3] gpu: fix module_init() usage Koen Koning
2026-02-19 21:38     ` [PATCH v3 1/3] gpu/buddy: " Koen Koning
2026-02-20  6:06       ` Greg KH
2026-02-20 10:17         ` Danilo Krummrich
2026-02-20 13:55           ` Joel Fernandes
2026-02-21  5:44             ` Greg KH
2026-02-23  0:49               ` Joel Fernandes
2026-02-23 11:17                 ` Koen Koning
2026-02-23 11:20                   ` Danilo Krummrich
2026-02-23 13:42                     ` Joel Fernandes
2026-02-23 22:31                     ` Danilo Krummrich
2026-02-24  3:41                       ` David Airlie
2026-02-19 21:38     ` [PATCH v3 2/3] drm/sched: " Koen Koning
2026-02-20  6:06       ` Greg KH
2026-02-19 21:38     ` [PATCH v3 3/3] drm/drv: " Koen Koning
2026-02-16 11:30 ` ✓ CI.KUnit: success for gpu: Fix uninitialized buddy for built-in drivers (rev2) Patchwork
2026-02-16 12:06 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-16 13:34 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-18  6:32 ` ✓ CI.KUnit: success for gpu: Fix uninitialized buddy for built-in drivers (rev3) Patchwork
2026-02-18  7:01 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-18  7:18 ` ✓ Xe.CI.FULL: " Patchwork
2026-02-18 13:16 ` ✓ CI.KUnit: success for gpu: Fix uninitialized buddy for built-in drivers (rev4) Patchwork
2026-02-18 13:51 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-18 15:27 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-23 22:30 ` Danilo Krummrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGMP3YT8VSCW.3OJRL3TK5PLRQ@kernel.org \
    --to=dakr@kernel.org \
    --cc=airlied@redhat.com \
    --cc=arunpravin.paneerselvam@amd.com \
    --cc=dri-devel-bounces@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=joelagnelf@nvidia.com \
    --cc=koen.koning@linux.intel.com \
    --cc=matthew.auld@intel.com \
    --cc=peter.senna@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox