intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/i915/backlight: Disable backlight when using luminance control
@ 2025-08-26  8:00 Suraj Kandpal
  2025-08-26  8:46 ` ✓ CI.KUnit: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Suraj Kandpal @ 2025-08-26  8:00 UTC (permalink / raw)
  To: intel-xe, intel-gfx; +Cc: arun.r.murthy, ankit.k.nautiyal, Suraj Kandpal

We just return when using luminance control instead we should be
calling the disable helper to get everything cleaned up properly.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 12084a542fc5..7306858467fe 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -508,10 +508,10 @@ static void intel_dp_aux_vesa_disable_backlight(const struct drm_connector_state
 	struct intel_panel *panel = &connector->panel;
 	struct intel_dp *intel_dp = enc_to_intel_dp(connector->encoder);
 
-	if (panel->backlight.edp.vesa.luminance_control_support)
+	if (panel->backlight.edp.vesa.luminance_control_support) {
+		drm_edp_backlight_disable(&intel_dp->aux, &panel->backlight.edp.vesa.info);
 		return;
-
-	drm_edp_backlight_disable(&intel_dp->aux, &panel->backlight.edp.vesa.info);
+	}
 
 	if (!panel->backlight.edp.vesa.info.aux_enable)
 		panel->backlight.pwm_funcs->disable(old_conn_state,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-09-02  8:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-26  8:00 [PATCH] drm/i915/backlight: Disable backlight when using luminance control Suraj Kandpal
2025-08-26  8:46 ` ✓ CI.KUnit: success for " Patchwork
2025-08-26  9:37 ` ✓ Xe.CI.BAT: " Patchwork
2025-08-26 15:54 ` ✗ Xe.CI.Full: failure " Patchwork
2025-09-02  8:29 ` [PATCH] " Murthy, Arun R

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).