From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 00/22] TLB Invalidation
Date: Wed, 8 Feb 2023 12:27:01 -0500 [thread overview]
Message-ID: <Y+PbZbxvrCV0I0hv@intel.com> (raw)
In-Reply-To: <Y+GBpdMmLUNZ52Ss@nvishwa1-DESK>
On Mon, Feb 06, 2023 at 02:39:33PM -0800, Niranjana Vishwanathapura wrote:
> On Fri, Feb 03, 2023 at 03:23:47PM -0500, Rodrigo Vivi wrote:
> > Let's just confirm the reviews on this patch and get them
> > merged to drm-xe-next.
> >
> > Matthew Brost (22):
> > drm/xe: Don't process TLB invalidation done in CT fast-path
> > drm/xe: Break of TLB invalidation into its own file
> > drm/xe: Move TLB invalidation variable to own sub-structure in GT
> > drm/xe: Add TLB invalidation fence
> > drm/xe: Invalidate TLB after unbind is complete
> > drm/xe: Kernel doc GT TLB invalidations
> > drm/xe: Add TLB invalidation fence ftrace
> > drm/xe: Fix build for CONFIG_DRM_XE_DEBUG
> > drm/xe: Add TDR for invalidation fence timeout cleanup
> > drm/xe: Only set VM->asid for platforms that support a ASID
> > drm/xe: Delete debugfs entry to issue TLB invalidation
> > drm/xe: Add has_range_tlb_invalidation device attribute
> > drm/xe: Add range based TLB invalidations
> > drm/xe: Propagate error from bind operations to async fence
> > drm/xe: Use GuC to do GGTT invalidations for the GuC firmware
> > drm/xe: Coalesce GGTT invalidations
> > drm/xe: Lock GGTT on when restoring kernel BOs
> > drm/xe: Propagate VM unbind error to invalidation fence
> > drm/xe: Signal invalidation fence immediately if CT send fails
> > drm/xe: Add has_asid to device info
> > drm/xe: Add TLB invalidation fence after rebinds issued from execs
> > drm/xe: Drop TLB invalidation from ring operations
> >
>
> Looks good to me.
> Some minor comments on patch ordering.
> Patch #8 can be merged with #10
did you mean squashed together?
but why 8 and 10? 8 is a build fix, so I'd assume the issue
happened in a previous patch, not in patch 10.
08 - drm/xe: Fix build for CONFIG_DRM_XE_DEBUG
10 - drm/xe: Only set VM->asid for platforms that support a ASID
> Patch #10 can be simplified if we move #20 before patch #10
indeed, but at this point I prefer to not touch them...
> Patch #17 should probably put ahead of #16
maybe a squash? but I will probably just leave it as is...
>
> In any case,
> Reviewed-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Thanks you so much
>
>
> > drivers/gpu/drm/xe/Makefile | 1 +
> > drivers/gpu/drm/xe/xe_bo_evict.c | 5 +-
> > drivers/gpu/drm/xe/xe_device.c | 14 +
> > drivers/gpu/drm/xe/xe_device_types.h | 4 +
> > drivers/gpu/drm/xe/xe_ggtt.c | 23 +-
> > drivers/gpu/drm/xe/xe_ggtt_types.h | 2 +
> > drivers/gpu/drm/xe/xe_gt.c | 19 +
> > drivers/gpu/drm/xe/xe_gt.h | 1 +
> > drivers/gpu/drm/xe/xe_gt_debugfs.c | 21 --
> > drivers/gpu/drm/xe/xe_gt_pagefault.c | 104 +-----
> > drivers/gpu/drm/xe/xe_gt_pagefault.h | 3 -
> > drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 342 ++++++++++++++++++
> > drivers/gpu/drm/xe/xe_gt_tlb_invalidation.h | 26 ++
> > .../gpu/drm/xe/xe_gt_tlb_invalidation_types.h | 28 ++
> > drivers/gpu/drm/xe/xe_gt_types.h | 41 ++-
> > drivers/gpu/drm/xe/xe_guc.c | 2 +
> > drivers/gpu/drm/xe/xe_guc_ct.c | 10 +-
> > drivers/gpu/drm/xe/xe_guc_types.h | 2 +
> > drivers/gpu/drm/xe/xe_lrc.c | 4 +-
> > drivers/gpu/drm/xe/xe_pci.c | 7 +
> > drivers/gpu/drm/xe/xe_pt.c | 130 +++++++
> > drivers/gpu/drm/xe/xe_ring_ops.c | 40 +-
> > drivers/gpu/drm/xe/xe_trace.h | 55 +++
> > drivers/gpu/drm/xe/xe_uc.c | 9 +-
> > drivers/gpu/drm/xe/xe_uc.h | 1 +
> > drivers/gpu/drm/xe/xe_vm.c | 42 ++-
> > 26 files changed, 736 insertions(+), 200 deletions(-)
> > create mode 100644 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> > create mode 100644 drivers/gpu/drm/xe/xe_gt_tlb_invalidation.h
> > create mode 100644 drivers/gpu/drm/xe/xe_gt_tlb_invalidation_types.h
> >
> > --
> > 2.39.1
> >
next prev parent reply other threads:[~2023-02-08 17:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 20:23 [Intel-xe] [PATCH 00/22] TLB Invalidation Rodrigo Vivi
2023-02-03 20:23 ` [Intel-xe] [PATCH 01/22] drm/xe: Don't process TLB invalidation done in CT fast-path Rodrigo Vivi
2023-02-03 20:23 ` [Intel-xe] [PATCH 02/22] drm/xe: Break of TLB invalidation into its own file Rodrigo Vivi
2023-02-03 20:23 ` [Intel-xe] [PATCH 03/22] drm/xe: Move TLB invalidation variable to own sub-structure in GT Rodrigo Vivi
2023-02-03 20:23 ` [Intel-xe] [PATCH 04/22] drm/xe: Add TLB invalidation fence Rodrigo Vivi
2023-02-03 20:23 ` [Intel-xe] [PATCH 05/22] drm/xe: Invalidate TLB after unbind is complete Rodrigo Vivi
2023-02-03 20:23 ` [Intel-xe] [PATCH 06/22] drm/xe: Kernel doc GT TLB invalidations Rodrigo Vivi
2023-02-13 23:21 ` Matt Roper
2023-02-17 16:22 ` Rodrigo Vivi
2023-02-03 20:23 ` [Intel-xe] [PATCH 07/22] drm/xe: Add TLB invalidation fence ftrace Rodrigo Vivi
2023-02-03 20:23 ` [Intel-xe] [PATCH 08/22] drm/xe: Fix build for CONFIG_DRM_XE_DEBUG Rodrigo Vivi
2023-02-13 23:22 ` Matt Roper
2023-02-17 16:24 ` Rodrigo Vivi
2023-02-03 20:23 ` [Intel-xe] [PATCH 09/22] drm/xe: Add TDR for invalidation fence timeout cleanup Rodrigo Vivi
2023-02-03 20:23 ` [Intel-xe] [PATCH 10/22] drm/xe: Only set VM->asid for platforms that support a ASID Rodrigo Vivi
2023-02-03 20:23 ` [Intel-xe] [PATCH 11/22] drm/xe: Delete debugfs entry to issue TLB invalidation Rodrigo Vivi
2023-02-03 20:23 ` [Intel-xe] [PATCH 12/22] drm/xe: Add has_range_tlb_invalidation device attribute Rodrigo Vivi
2023-02-03 20:24 ` [Intel-xe] [PATCH 13/22] drm/xe: Add range based TLB invalidations Rodrigo Vivi
2023-02-03 20:24 ` [Intel-xe] [PATCH 14/22] drm/xe: Propagate error from bind operations to async fence Rodrigo Vivi
2023-02-03 20:24 ` [Intel-xe] [PATCH 15/22] drm/xe: Use GuC to do GGTT invalidations for the GuC firmware Rodrigo Vivi
2023-02-03 20:24 ` [Intel-xe] [PATCH 16/22] drm/xe: Coalesce GGTT invalidations Rodrigo Vivi
2023-02-03 20:24 ` [Intel-xe] [PATCH 17/22] drm/xe: Lock GGTT on when restoring kernel BOs Rodrigo Vivi
2023-02-03 20:24 ` [Intel-xe] [PATCH 18/22] drm/xe: Propagate VM unbind error to invalidation fence Rodrigo Vivi
2023-02-03 20:24 ` [Intel-xe] [PATCH 19/22] drm/xe: Signal invalidation fence immediately if CT send fails Rodrigo Vivi
2023-02-03 20:24 ` [Intel-xe] [PATCH 20/22] drm/xe: Add has_asid to device info Rodrigo Vivi
2023-02-03 20:24 ` [Intel-xe] [PATCH 21/22] drm/xe: Add TLB invalidation fence after rebinds issued from execs Rodrigo Vivi
2023-02-03 20:24 ` [Intel-xe] [PATCH 22/22] drm/xe: Drop TLB invalidation from ring operations Rodrigo Vivi
2023-02-06 22:39 ` [Intel-xe] [PATCH 00/22] TLB Invalidation Niranjana Vishwanathapura
2023-02-08 17:27 ` Rodrigo Vivi [this message]
2023-02-09 4:54 ` Niranjana Vishwanathapura
2023-02-09 4:59 ` Niranjana Vishwanathapura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+PbZbxvrCV0I0hv@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=niranjana.vishwanathapura@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox