From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02BC8C3600B for ; Thu, 27 Mar 2025 22:45:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C111B10E183; Thu, 27 Mar 2025 22:45:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="kuhF1r5v"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 17A9210E183 for ; Thu, 27 Mar 2025 22:45:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743115551; x=1774651551; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=MwyQfIvAHWeTnpbzd7q8PEbPhquj28W/cyZQ+1eYZbs=; b=kuhF1r5vCRzNAd3CXRl/hv/9fGQKOPwDAGNW3sYNkw7M1cTUKLSPQZSo /eIOQ/BcK5bb04j6XXMhDIDBrWslcSk26xy49Efazk9mg7A+Z4U8Guk6J N/gUeh0WiL2Sy1qeLZz6I6xn/XsULvH+uOm3X/V9pCDNVYXF57SOc3XKY RJcGUq4AVNrZq2khdmmWYGrg07ZBZJOWT7LnWm9YSS3z+75Zf37MHTLeV H9h78lFbte0cB4CtRt3efME8Ung4UVMRSxrBs/v1U1Ut+JraZS8CZXaQA lRgLvkzsSAQTXf0JROehAvRBAsZ46UGN/YQ1qx4nHs//NZO77kF8Y9LGq Q==; X-CSE-ConnectionGUID: 8qfrmM/fT3mIDWFRJDy0qg== X-CSE-MsgGUID: qj+VdRIGQDalyBh+adms2A== X-IronPort-AV: E=McAfee;i="6700,10204,11385"; a="55841821" X-IronPort-AV: E=Sophos;i="6.14,281,1736841600"; d="scan'208";a="55841821" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2025 15:45:50 -0700 X-CSE-ConnectionGUID: CBxA5IWsTiuifmmchUBuYg== X-CSE-MsgGUID: S3KGnNmzQ7GZKqQCaRGfJA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,281,1736841600"; d="scan'208";a="125033446" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2025 15:45:50 -0700 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 27 Mar 2025 15:45:50 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Thu, 27 Mar 2025 15:45:50 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 27 Mar 2025 15:45:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cALjiGNAaT4+OmJ8ys0XH80rgMCO4ucq7tLUCZ30T6T0Cr6/6A2Z8j+7bJFcC63bPBF/sKlcotxy37VTNredCW6vM5uyJxNX+qwQeVE+TzU+sPG5TPWRUJixn8J+723kiCjl7P3fN0Zdx2zHtRLPtGyocwY0mSgwgieYa8dx3XpDWCXSss0ON2eFEttxohkDY6kc/5A1/H3mmeMI6vGI/K/H7CymcrWLjr0rmL8OF+p3E6ZLKi+Puu+4Sg/1/utKC42yKuMFVdV2Qx25MROkTHaEW/+Ls+Dx3sN00cXxPiY+awbXc3nf1y2eCI+xvHHTAGiu1ox/77DSHBALfFusbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=njgL6dcXI0udiLlQm/3Pl6ZoPH3pLE5kAuzEMoC1O50=; b=bXKOBkEFSENe/WhOaggwSg/LrweQ5wakruk3Up3i3WL4aqUgy7pFXhkBdJ+Gzv7FdY4L2bAB54BHJ1YninfVOviXmgGBOYGzF329LoqRkH7FlA/jzs3rHkEC/28i4lcfnBa6O0KjWNtvR8R4miGdGzS7fq+6lET0GNXBUFI/nzAjPajZyYaH0g/89vSp200lFvT8QWF/mDXFOmUpWnUStV0jKL8zD78MX9oXr805xAx6UGMROggUf0GxbyQuSRDROF2+Gj7NPYK1umWRFINE2Uieh5bRe81lIjnj6UMzVuwXjjL8eaKJLS37v+ca3wVaA+UmAoV5cRNKXq1uGo7YkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) by DS0PR11MB6423.namprd11.prod.outlook.com (2603:10b6:8:c5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.44; Thu, 27 Mar 2025 22:45:43 +0000 Received: from PH7PR11MB6522.namprd11.prod.outlook.com ([fe80::9e94:e21f:e11a:332]) by PH7PR11MB6522.namprd11.prod.outlook.com ([fe80::9e94:e21f:e11a:332%3]) with mapi id 15.20.8534.043; Thu, 27 Mar 2025 22:45:43 +0000 Date: Thu, 27 Mar 2025 15:46:56 -0700 From: Matthew Brost To: Himal Prasad Ghimiray CC: , , Subject: Re: [RFC 05/29] drm/xe/svm: Make xe_svm_range_* end/start/size public Message-ID: References: <20250314080226.2059819-1-himal.prasad.ghimiray@intel.com> <20250314080226.2059819-6-himal.prasad.ghimiray@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250314080226.2059819-6-himal.prasad.ghimiray@intel.com> X-ClientProxiedBy: MW4PR03CA0324.namprd03.prod.outlook.com (2603:10b6:303:dd::29) To PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB6522:EE_|DS0PR11MB6423:EE_ X-MS-Office365-Filtering-Correlation-Id: 99f59254-20ba-4b89-569f-08dd6d811b2f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?HMg9A1EJoKAEsUeNOmwWex7JjuxY5mXyNOb/o3dRG8FsWdxv+vi37ent/NwE?= =?us-ascii?Q?woHOOE/axYQt7F606fYhwyq5FnkbVJUYlp7t63rv+cAlqAdbjN9KGqwEc90h?= =?us-ascii?Q?5+oCUa+wnXZpS1ATXwNQTH4eLrk/9IuLzbVpJqdE2YirA1IFsDZP/Nncb/e9?= =?us-ascii?Q?t0NPgo6kfvmcWD+Uqent2tQguLqL17gi0qdlB0dyK5+b9OH4YBuwVaGK3P9H?= =?us-ascii?Q?4MHt2R2Iw7PyuXHSqNYfc6R4fLc/VwdP9277n0aWZKzCCZASKQ3JmFzgjh3O?= =?us-ascii?Q?l9qhgpe/F25T09VsiNpWbnqT00SqN9hcecOzvArbU7wa7TTAyX2LvEG/zF8H?= =?us-ascii?Q?Jwazy4K/mWJfvkypu82qbxZGgBQHncCWr7TDlxZaIoc6iXtiv6hac8awrFxS?= =?us-ascii?Q?oCdhj/XCpQi7xc7kyH22IgwDI74Xc6ti09PseMi7g1mquSJL+wcp3iSaRoPc?= =?us-ascii?Q?A45dqZozRPcy3ceZ4LDwydfg/v6DbYYZdY+ltyYAbF5bXCGxcvQyhBJz6I7y?= =?us-ascii?Q?U7af8NXVkmvDEgfWNeQBoKqGpodYcT2zk0AC7rR0MG3DypJJV/7veLC6k/Wj?= =?us-ascii?Q?gLtjbYuNQn8XB/NsTEjhPgwCC/pat1l8ahoUGmOSjLY/UWhym0viXxuEEyga?= =?us-ascii?Q?SuYbeMNW+nUtxX/6Yd74MoARcYRj6s6M9EoTg/+AI1VfpwByacZh9pebJduW?= =?us-ascii?Q?11QgO+uE1drcFFAk5amXS2J8qTuu9AZLV5DjUnrgjVOsFn5Z9deoI1iTDeDb?= =?us-ascii?Q?TA4CwaNLF/Z6McyyOyBfs9EomziD2fuFghoP3x+8eRLu9np74WZPVsYA8jbu?= =?us-ascii?Q?oYeBigxNYBb0tLhygxGp3Tog/vwBDSW7AJmsijTAthL+lxUpCVWfUj759KSC?= =?us-ascii?Q?bA3JaZX6WkmsJFvfpcxqeheShwIlnM12rpY5KlvlfeSK+DFd4atckmO6RO84?= =?us-ascii?Q?UeO5JPYMHWzxBbt73Zw/lM0iZnGO0Psb6T1cGMuIsKfG+swWp1YOTgWi1PkH?= =?us-ascii?Q?OJ3RWxMb8jFcI3uXYzFtsXGqnD3NwX5kQ1jjlNA5QskeBo8pBPkApWXuOD8x?= =?us-ascii?Q?InWXpvdunprk/SDuNGS8X34mbges9S0dLipZkNXSj3MpUfL9GaSQWgEwEr1M?= =?us-ascii?Q?SUZLEdaanPGZsrSir1QnxHH3R1snv5eV8rkHNl+L0ze7NDGB3vOhABgq2F3d?= =?us-ascii?Q?CUMbTE0AzQF80IJzBNG/ODr8TFhpah7jhmIfXX0Tsi8A+oNoVCl9hi3Elx4w?= =?us-ascii?Q?y2NoRuaCbz/Kz9e5Abilt67U5IiOJg++fuX2tGvS/Kn+FSJvjO/BvE9IkOoZ?= =?us-ascii?Q?pMJ1hVQC1SfxM4yVTtv3+F+ewI8qp9D7iYLEReg4YO2OgxGHBj/GWmZoKbpw?= =?us-ascii?Q?/yLosq53JWnRDWQSbti/dupwYk9Z?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6522.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TNHKX0x27XOsYjvhDPyV3EIu2WCtwJtRtz1Pd4bwJLNhrfApQsMrlZVn6yNz?= =?us-ascii?Q?O2+Qw1iSgqKLMRHh8jDvMzGlAtz7/uhYh9IUtiLDj4dNYj2rSBYEMbdYDfli?= =?us-ascii?Q?hTDsnOD7Ltl+kZQKypZNYGL2nSN3MiQp4BNzsm9zmQos+xE71+upoTMnJpyw?= =?us-ascii?Q?LGQQgVTusuR5lhhB9PCGTaXMHV7yJpeDmGm6zBYGXsy8XFLijs8J7f6tfHqo?= =?us-ascii?Q?HC3OQ8c4/PsQekyGQCilTar+CIRpCa/QLOMEuYZICcplStkUsFRbtepsaY59?= =?us-ascii?Q?5D4rB1YCf+LBTiLl40LO/2mB3ElU/a00JWXk3hGtStxnVEXyTZqu9zU7BpHl?= =?us-ascii?Q?0barOEGHCaogj708ZJ5CC4hwfaYWOaDVSzgVwbxgglxmRYHHCtMgwHjQXQKw?= =?us-ascii?Q?9sDpgo6nhJnQuJ+5TRTmkcqAd30PIGejIFPGiVvXldewF+frUB/amNW96QmV?= =?us-ascii?Q?ATEJURr2JHilFM7FusmNRFrOuZZh06aIynYuIcoSpQ+Bpas9OSlR0atPk7GI?= =?us-ascii?Q?GaQrekRyGNAkD8bb+1cBTnDwW4KbSdg/nOue2ztoClh1YKi02v305jGbBRpM?= =?us-ascii?Q?h/U05R1grWk1Ial/mk3+XwEHZqBsnhXQtss98fcBGmcdvt7HieVswibeXSyi?= =?us-ascii?Q?KWgO0UumPU/ocsWZh2GDVCpv9iTtRW9R6PxdggFEQ7wzaVJieXbt2Sqm2SrY?= =?us-ascii?Q?xXwnsir1Xg2fzR7x1ZRrJ7gS91apYZ1X3SvG+abLdRwRYaTtqFZRqSjgF2O5?= =?us-ascii?Q?PhDoRip2YtIcgXT+7SAIBl0LmaYNKWrGjselBvukHyhSoL9KJj7hh0UDKOGN?= =?us-ascii?Q?XvsX/30XMMoHI5kBtAGx5yl/4kVWhNt/YLDjqfJu2hZVFrnpHVhZC4aAlhiR?= =?us-ascii?Q?aX80choL36yDrH0nJ1kcMIax0RmULKF8msdo3pJVKGpwctGBxHRniq64qsP0?= =?us-ascii?Q?cBVpZHQSekW4CA57vV6ElZ8C4sM+j+mUYYptNOR+sxQ1NfO18x5zK/UZkRoK?= =?us-ascii?Q?4/NiSroyVXv2Joy3O4/XZvOs+CetwCh/NvjkyatFzOPzoSpUgboHkkZAYMnb?= =?us-ascii?Q?Mb7RauQLnEng+b3689FHHfysg2lcS0HoDNLk6wE6GZfBwVetm0SQP+EsNQH3?= =?us-ascii?Q?QFEkMlu+rzKRY0BJ2/1RM6H8E79gZr0vhGVeLVpig4Cb203iIJqHkNj7lXZA?= =?us-ascii?Q?ZD97kTpcCHNDJBkpJZmEdnNN67ZU/yyQERde47SNrUhKiNJHK2l22e0ZL3Ie?= =?us-ascii?Q?lGJkb8YJ/1JbXhw15pJg5th+ObGIxRmIETND4zf5hi2+i4QuDlpWS1pH2lcv?= =?us-ascii?Q?MS0jDnquFOtKx8g/9PCzlb5yWQ498WuUUvP0YAAVxD6VfP3KPrOhWerH651r?= =?us-ascii?Q?9sUJI8U/MWyoTpvxpa8q9l/7mp42aLtK/uqqr7sYgOSQ0J4iAEnHx3yqjmgi?= =?us-ascii?Q?FajHl7T91iZ6gNFIvlY6BiaN6lUNS7mANzPJ6HWgUxL9RDlwqoElFHxs00R1?= =?us-ascii?Q?7T9PoLFV/P26vpJmTwRu7eukJMYoCVwTp7sUtU7W4AMiQ+Pts9dpljku38kQ?= =?us-ascii?Q?/io7IhF91yYJdop9PJkC0SetzTkFgPPeCYNe4d7sJ7RpUOc6qaa08NCE7kvG?= =?us-ascii?Q?FQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 99f59254-20ba-4b89-569f-08dd6d811b2f X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6522.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2025 22:45:43.2108 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: edl6b51KuYN2kC4/SZAhu+4w9V70R/OOakOgTtmD8y2ALYQknzqfTTCiNOiI7yyAh/taQCWNDnYlBOPHjAMuZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6423 X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, Mar 14, 2025 at 01:32:02PM +0530, Himal Prasad Ghimiray wrote: > These functions will be used in prefetch too, therefore make them public. > > Signed-off-by: Himal Prasad Ghimiray > --- > drivers/gpu/drm/xe/xe_svm.c | 15 --------------- > drivers/gpu/drm/xe/xe_svm.h | 32 ++++++++++++++++++++++++++++++++ > 2 files changed, 32 insertions(+), 15 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c > index 2b041f44730b..07511011aba6 100644 > --- a/drivers/gpu/drm/xe/xe_svm.c > +++ b/drivers/gpu/drm/xe/xe_svm.c > @@ -35,21 +35,6 @@ static struct xe_vm *range_to_vm(struct drm_gpusvm_range *r) > return gpusvm_to_vm(r->gpusvm); > } > > -static unsigned long xe_svm_range_start(struct xe_svm_range *range) > -{ > - return drm_gpusvm_range_start(&range->base); > -} > - > -static unsigned long xe_svm_range_end(struct xe_svm_range *range) > -{ > - return drm_gpusvm_range_end(&range->base); > -} > - > -static unsigned long xe_svm_range_size(struct xe_svm_range *range) > -{ > - return drm_gpusvm_range_size(&range->base); > -} > - > #define range_debug(r__, operaton__) \ > vm_dbg(&range_to_vm(&(r__)->base)->xe->drm, \ > "%s: asid=%u, gpusvm=%p, vram=%d,%d, seqno=%lu, " \ > diff --git a/drivers/gpu/drm/xe/xe_svm.h b/drivers/gpu/drm/xe/xe_svm.h > index 1af245400799..c8add37614ec 100644 > --- a/drivers/gpu/drm/xe/xe_svm.h > +++ b/drivers/gpu/drm/xe/xe_svm.h > @@ -165,6 +165,38 @@ static inline bool xe_svm_range_has_dma_mapping(struct xe_svm_range *range) > return range->base.flags.has_dma_mapping; > } > > +/** > + * xe_svm_range_start() - SVM range start address > + * @range: SVM range > + * > + * Return: start address of range. > + */ > +static inline unsigned long xe_svm_range_start(struct xe_svm_range *range) > +{ > + return drm_gpusvm_range_start(&range->base); > +} > + > +/** > + * xe_svm_range_start() - SVM range end address > + * @range: SVM range > + * > + * Return: end address of range. > + */ > +static inline unsigned long xe_svm_range_end(struct xe_svm_range *range) > +{ > + return drm_gpusvm_range_end(&range->base); > +} > + > +/** > + * xe_svm_range_start() - SVM range size > + * @range: SVM range > + * > + * Return: Size of range. > + */ > +static inline unsigned long xe_svm_range_size(struct xe_svm_range *range) > +{ > + return drm_gpusvm_range_size(&range->base); > +} Need an extra newline here. With that: Reviewed-by: Matthew Brost > #define xe_svm_assert_in_notifier(vm__) \ > lockdep_assert_held_write(&(vm__)->svm.gpusvm.notifier_lock) > > -- > 2.34.1 >