From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-xe@lists.freedesktop.org,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/xe/vm_doc: fix more doc typos
Date: Mon, 2 Dec 2024 15:02:56 -0500 [thread overview]
Message-ID: <Z04ScOZKhLIGI_MU@intel.com> (raw)
In-Reply-To: <20241128035901.375399-1-rdunlap@infradead.org>
On Wed, Nov 27, 2024 at 07:58:59PM -0800, Randy Dunlap wrote:
> Fix all typos in xe_vm_doc.h as reported by codespell.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: intel-xe@lists.freedesktop.org
> Cc: David Airlie <airlied@gmail.com>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/xe/xe_vm_doc.h | 22 +++++++++++-----------
Although I want to kill the _doc.h files and this file is likely
outdated, let's at least go ahead with fixing the typos...
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> --- linux-next-20241125.orig/drivers/gpu/drm/xe/xe_vm_doc.h
> +++ linux-next-20241125/drivers/gpu/drm/xe/xe_vm_doc.h
> @@ -64,8 +64,8 @@
> * update page level 2 PDE[1] to page level 3b phys address (GPU)
> *
> * bind BO2 0x1ff000-0x201000
> - * update page level 3a PTE[511] to BO2 phys addres (GPU)
> - * update page level 3b PTE[0] to BO2 phys addres + 0x1000 (GPU)
> + * update page level 3a PTE[511] to BO2 phys address (GPU)
> + * update page level 3b PTE[0] to BO2 phys address + 0x1000 (GPU)
> *
> * GPU bypass
> * ~~~~~~~~~~
> @@ -192,7 +192,7 @@
> *
> * If a VM is in fault mode (TODO: link to fault mode), new bind operations that
> * create mappings are by default deferred to the page fault handler (first
> - * use). This behavior can be overriden by setting the flag
> + * use). This behavior can be overridden by setting the flag
> * DRM_XE_VM_BIND_FLAG_IMMEDIATE which indicates to creating the mapping
> * immediately.
> *
> @@ -209,7 +209,7 @@
> *
> * Since this a core kernel managed memory the kernel can move this memory
> * whenever it wants. We register an invalidation MMU notifier to alert XE when
> - * a user poiter is about to move. The invalidation notifier needs to block
> + * a user pointer is about to move. The invalidation notifier needs to block
> * until all pending users (jobs or compute mode engines) of the userptr are
> * idle to ensure no faults. This done by waiting on all of VM's dma-resv slots.
> *
> @@ -252,7 +252,7 @@
> * Rebind worker
> * -------------
> *
> - * The rebind worker is very similar to an exec. It is resposible for rebinding
> + * The rebind worker is very similar to an exec. It is responsible for rebinding
> * evicted BOs or userptrs, waiting on those operations, installing new preempt
> * fences, and finally resuming executing of engines in the VM.
> *
> @@ -317,11 +317,11 @@
> * are not allowed, only long running workloads and ULLS are enabled on a faulting
> * VM.
> *
> - * Defered VM binds
> + * Deferred VM binds
> * ----------------
> *
> * By default, on a faulting VM binds just allocate the VMA and the actual
> - * updating of the page tables is defered to the page fault handler. This
> + * updating of the page tables is deferred to the page fault handler. This
> * behavior can be overridden by setting the flag DRM_XE_VM_BIND_FLAG_IMMEDIATE in
> * the VM bind which will then do the bind immediately.
> *
> @@ -500,18 +500,18 @@
> * Slot waiting
> * ------------
> *
> - * 1. The exection of all jobs from kernel ops shall wait on all slots
> + * 1. The execution of all jobs from kernel ops shall wait on all slots
> * (DMA_RESV_USAGE_PREEMPT_FENCE) of either an external BO or VM (depends on if
> * kernel op is operating on external or private BO)
> *
> - * 2. In non-compute mode, the exection of all jobs from rebinds in execs shall
> + * 2. In non-compute mode, the execution of all jobs from rebinds in execs shall
> * wait on the DMA_RESV_USAGE_KERNEL slot of either an external BO or VM
> * (depends on if the rebind is operatiing on an external or private BO)
> *
> - * 3. In non-compute mode, the exection of all jobs from execs shall wait on the
> + * 3. In non-compute mode, the execution of all jobs from execs shall wait on the
> * last rebind job
> *
> - * 4. In compute mode, the exection of all jobs from rebinds in the rebind
> + * 4. In compute mode, the execution of all jobs from rebinds in the rebind
> * worker shall wait on the DMA_RESV_USAGE_KERNEL slot of either an external BO
> * or VM (depends on if rebind is operating on external or private BO)
> *
prev parent reply other threads:[~2024-12-02 20:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 3:58 [PATCH] drm/xe/vm_doc: fix more doc typos Randy Dunlap
2024-11-28 4:05 ` ✓ CI.Patch_applied: success for " Patchwork
2024-11-28 4:05 ` ✓ CI.checkpatch: " Patchwork
2024-11-28 4:07 ` ✓ CI.KUnit: " Patchwork
2024-11-28 4:24 ` ✓ CI.Build: " Patchwork
2024-11-28 4:27 ` ✓ CI.Hooks: " Patchwork
2024-11-28 4:28 ` ✓ CI.checksparse: " Patchwork
2024-11-28 4:48 ` ✓ Xe.CI.BAT: " Patchwork
2024-11-28 5:45 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-02 20:02 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z04ScOZKhLIGI_MU@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=rdunlap@infradead.org \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox