Re: [PATCH 2/3] drm/xe: Print vm flags in xe_vm trace print

[Matthew Brost <matthew.brost@intel.com>]

On Tue, Dec 17, 2024 at 06:14:19PM -0500, Oak Zeng wrote:
> Print vm flags in xe_vm trace print.
> 

I was told we should try to have better commit messages. Maybe add why
this useful. e.g., Flags help diagnosis the VM mode of operation.

> Signed-off-by: Oak Zeng <oak.zeng@intel.com>

With a better commit message:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_trace_bo.h | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_trace_bo.h b/drivers/gpu/drm/xe/xe_trace_bo.h
> index 53807f2ef4808..a46f7cfd92c6f 100644
> --- a/drivers/gpu/drm/xe/xe_trace_bo.h
> +++ b/drivers/gpu/drm/xe/xe_trace_bo.h
> @@ -190,16 +190,19 @@ DECLARE_EVENT_CLASS(xe_vm,
>  			     __string(dev, __dev_name_vm(vm))
>  			     __field(struct xe_vm *, vm)
>  			     __field(u32, asid)
> +			     __field(u32, flags)
>  			     ),
>  
>  		    TP_fast_assign(
>  			   __assign_str(dev);
>  			   __entry->vm = vm;
>  			   __entry->asid = vm->usm.asid;
> +			   __entry->flags = vm->flags;
>  			   ),
>  
> -		    TP_printk("dev=%s, vm=%p, asid=0x%05x", __get_str(dev),
> -			      __entry->vm, __entry->asid)
> +		    TP_printk("dev=%s, vm=%p, asid=0x%05x, vm flags=0x%05x",
> +			      __get_str(dev), __entry->vm, __entry->asid,
> +			      __entry->flags)
>  );
>  
>  DEFINE_EVENT(xe_vm, xe_vm_kill,
> -- 
> 2.26.3
>