From: Imre Deak <imre.deak@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Kahola, Mika" <mika.kahola@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/i915/display: UHBR rates for Thunderbolt
Date: Thu, 19 Dec 2024 15:18:32 +0200 [thread overview]
Message-ID: <Z2QdKA2hlum-XNEQ@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <871py3rjm8.fsf@intel.com>
On Thu, Dec 19, 2024 at 01:35:11PM +0200, Jani Nikula wrote:
> On Thu, 19 Dec 2024, "Kahola, Mika" <mika.kahola@intel.com> wrote:
> > Thanks for the review! Patch is now merged with the change of naming
> > to XE3_*. This is used elsewhere in the driver so maybe it's ok to use
> > here as well.
>
> Nag, I don't really like modifying patches while applying. Personally, I
> try to avoid it altogether, occasionally changing whitespace or
> comments, but hardly ever anything functional.
Ok, noted, will ask for a resend in the future in such cases.
> BR,
> Jani.
>
>
> --
> Jani Nikula, Intel
next prev parent reply other threads:[~2024-12-19 13:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 14:34 [PATCH v2] drm/i915/display: UHBR rates for Thunderbolt Mika Kahola
2024-12-17 19:45 ` ✓ CI.Patch_applied: success for drm/i915/display: UHBR rates for Thunderbolt (rev2) Patchwork
2024-12-17 19:45 ` ✗ CI.checkpatch: warning " Patchwork
2024-12-17 19:46 ` ✓ CI.KUnit: success " Patchwork
2024-12-17 20:04 ` ✓ CI.Build: " Patchwork
2024-12-17 20:07 ` ✓ CI.Hooks: " Patchwork
2024-12-17 20:08 ` ✓ CI.checksparse: " Patchwork
2024-12-18 5:30 ` ✓ CI.BAT: " Patchwork
2024-12-18 14:56 ` [PATCH v2] drm/i915/display: UHBR rates for Thunderbolt Imre Deak
2024-12-19 11:16 ` Kahola, Mika
2024-12-19 11:35 ` Jani Nikula
2024-12-19 13:18 ` Imre Deak [this message]
2024-12-24 21:01 ` Gustavo Sousa
2024-12-30 16:25 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2QdKA2hlum-XNEQ@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox