From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 464A9C02180 for ; Mon, 13 Jan 2025 13:45:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C21710E317; Mon, 13 Jan 2025 13:45:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=minyard-net.20230601.gappssmtp.com header.i=@minyard-net.20230601.gappssmtp.com header.b="3YK8ds2H"; dkim-atps=neutral Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by gabe.freedesktop.org (Postfix) with ESMTPS id E3A2610EEBB for ; Thu, 9 Jan 2025 15:45:36 +0000 (UTC) Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-71e35be77b5so294449a34.1 for ; Thu, 09 Jan 2025 07:45:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard-net.20230601.gappssmtp.com; s=20230601; t=1736437536; x=1737042336; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=cgTp2x21PamB5G5tjbV3jPSQRWSgTUkiJmrzV93coW4=; b=3YK8ds2H9Nd+Y+98VlUVvTplicy5vrI0vhUEfHZZkjlL8BCUO5rWp57akp5jAohdmr M56uC9FuI7IxMdez94uzVaTyDMy2BthmHXRNiQ36JN/PBZ9oJYV6bz8qXTdDQBMUF70y zvkYQ4i1JrN+C1Gc4dRqEk2Wvt+ezshU1qN0Lw7Lv6XYhhymkHquPVZRcTXaMFewK9Wh NwLt/pnksnYFEXuRcMoP6q+qAGzMM516UfGVzGvmUFff6FOjnteBtU9e0YZpiPGUCjXS jajwG1swVZWBjZdn9knxY+kScl5haz5S0v73tx5oiXDXPKToovzB0+bjTwEhBt21J47Q k7SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736437536; x=1737042336; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cgTp2x21PamB5G5tjbV3jPSQRWSgTUkiJmrzV93coW4=; b=Sy3rjdQk5xuZQqs11EDobN4V4v6Jbt4jTSrrs6t6ha+LkSF4OxgvCpYL3GvId6a+0Q jKkTYhOO3lQPAYMFxvZu4ZxfGEz/B21+D8pN6dpHICVjPdK5Trt1dd+PSdfStoD89UJY LmIQyBMc8rQ+NuqReR2ZtJSz+yivnpygtLZ8NA3AblBlCwlsAfcHDnG4QG8RniRqnYyO NnRTNOU5Y3K1jl9kXImdconi6QJQWuFAC4RhLayixaizOLya5TT2ticqJ8yV6NPjF67S OU5HhvmXe2AynbQyJ6YxI3i/Fe8sZ7DH16LR8emZfYVHrmobPBZwQljrjApdu2yxogLJ 3clA== X-Forwarded-Encrypted: i=1; AJvYcCUZ12eGGaY80YQRxqRZmHz5fNRva0zGxGsvTes/7H4SsyR7Rm7l742UtowhNsf9Iphk2HXSPm535Q==@lists.freedesktop.org X-Gm-Message-State: AOJu0YzhZF90KW3nKxeClHghfSCA9bRpHdcEOZh2OctVkq8bzmJQWWgV I9WbHj0nodjHeIRGnwst3Xn6zpBz9jML78kX4XUBLHinQ/yw7OFYyefb3AfnuXc= X-Gm-Gg: ASbGncuP9NeJNd8Ipc2bLWGz5/2AwYXcK+oeGuzYL46os1hqY27kRH1rBQxVZu6wRTj sGZCROscNfCZUGIU5hqI6Vq6KiPmgScV6+daaq7SdP8BGd79crlYqdwV+o3rsGbXzmA0AiEolry a3ZWG08EKSi3+QpoyNZ45m7nad+oHsF5cYHyJE45l9AvvA1Igf9U9jHuCt/ippKqPYP3XrPtOq6 KpX5KqP9cDSjF0hOBdhGKjabFhDSLHrTpRaZQ8Lp5yfla29YLHEpkmtIKIy X-Google-Smtp-Source: AGHT+IHELUnxP9ZvL+e2Ztemz39I9ORoPYZLTVwEa+XG73J5uz7w7yM0cuXu9KZqTaUsGk+1/+jmGA== X-Received: by 2002:a05:6830:6610:b0:716:a95d:9ef with SMTP id 46e09a7af769-721e2e000d6mr4949630a34.2.1736437534534; Thu, 09 Jan 2025 07:45:34 -0800 (PST) Received: from mail.minyard.net ([2001:470:b8f6:1b:9076:47eb:1e0a:16fb]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5f882625f0esm386258eaf.9.2025.01.09.07.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 07:45:34 -0800 (PST) Date: Thu, 9 Jan 2025 09:45:27 -0600 From: Corey Minyard To: Joel Granados Cc: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Kees Cook , Luis Chamberlain , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, openipmi-developer@lists.sourceforge.net, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-hyperv@vger.kernel.org, linux-rdma@vger.kernel.org, linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org, xen-devel@lists.xenproject.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev, codalist@coda.cs.cmu.edu, linux-mm@kvack.org, linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev, fsverity@lists.linux.dev, linux-xfs@vger.kernel.org, io-uring@vger.kernel.org, bpf@vger.kernel.org, kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH] treewide: const qualify ctl_tables where applicable Message-ID: References: <20250109-jag-ctl_table_const-v1-1-622aea7230cf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250109-jag-ctl_table_const-v1-1-622aea7230cf@kernel.org> X-Mailman-Approved-At: Mon, 13 Jan 2025 13:45:52 +0000 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: corey@minyard.net Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, Jan 09, 2025 at 02:16:39PM +0100, Joel Granados wrote: > Add the const qualifier to all the ctl_tables in the tree except the > ones in ./net dir. The "net" sysctl code is special as it modifies the > arrays before passing it on to the registration function. > ... > diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c > index 941d2dcc8c9d..de84f59468a9 100644 > --- a/drivers/char/ipmi/ipmi_poweroff.c > +++ b/drivers/char/ipmi/ipmi_poweroff.c > @@ -650,7 +650,7 @@ static struct ipmi_smi_watcher smi_watcher = { > #ifdef CONFIG_PROC_FS > #include > > -static struct ctl_table ipmi_table[] = { > +static const struct ctl_table ipmi_table[] = { > { .procname = "poweroff_powercycle", > .data = &poweroff_powercycle, > .maxlen = sizeof(poweroff_powercycle), For the IPMI portion: Acked-by: Corey Minyard