Re: [PATCH 2/2] drm/xe: Remove "graphics tile" from kernel doc

[Matthew Brost <matthew.brost@intel.com>]

On Thu, Jan 02, 2025 at 04:11:11PM -0800, Lucas De Marchi wrote:
> Avoid using "graphics tile" to refer to GT since it's ambiguous: it's
> **part** of a tile and there's also "media gt". In several places it's
> documented as "GT structure", so just follow it.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_exec_queue_types.h    |  2 +-
>  drivers/gpu/drm/xe/xe_gt_stats.c            |  4 ++--
>  drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c | 12 ++++++------
>  drivers/gpu/drm/xe/xe_hw_engine_types.h     |  2 +-
>  drivers/gpu/drm/xe/xe_hw_fence_types.h      |  2 +-
>  5 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue_types.h b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> index eec8f9935a58e..5af5419cec7a6 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue_types.h
> +++ b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> @@ -41,7 +41,7 @@ struct xe_exec_queue {
>  	/** @xef: Back pointer to xe file if this is user created exec queue */
>  	struct xe_file *xef;
>  
> -	/** @gt: graphics tile this exec queue can submit to */
> +	/** @gt: GT structure this exec queue can submit to */
>  	struct xe_gt *gt;
>  	/**
>  	 * @hwe: A hardware of the same class. May (physical engine) or may not
> diff --git a/drivers/gpu/drm/xe/xe_gt_stats.c b/drivers/gpu/drm/xe/xe_gt_stats.c
> index c7364a5aef8fa..7a6c1d808e419 100644
> --- a/drivers/gpu/drm/xe/xe_gt_stats.c
> +++ b/drivers/gpu/drm/xe/xe_gt_stats.c
> @@ -12,7 +12,7 @@
>  
>  /**
>   * xe_gt_stats_incr - Increments the specified stats counter
> - * @gt: graphics tile
> + * @gt: GT structure
>   * @id: xe_gt_stats_id type id that needs to be incremented
>   * @incr: value to be incremented with
>   *
> @@ -32,7 +32,7 @@ static const char *const stat_description[__XE_GT_STATS_NUM_IDS] = {
>  
>  /**
>   * xe_gt_stats_print_info - Print the GT stats
> - * @gt: graphics tile
> + * @gt: GT structure
>   * @p: drm_printer where it will be printed out.
>   *
>   * This prints out all the available GT stats.
> diff --git a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> index 257b500e17037..0a93831c0a025 100644
> --- a/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> +++ b/drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c
> @@ -107,7 +107,7 @@ static void xe_gt_tlb_fence_timeout(struct work_struct *work)
>  
>  /**
>   * xe_gt_tlb_invalidation_init_early - Initialize GT TLB invalidation state
> - * @gt: graphics tile
> + * @gt: GT structure
>   *
>   * Initialize GT TLB invalidation state, purely software initialization, should
>   * be called once during driver load.
> @@ -128,7 +128,7 @@ int xe_gt_tlb_invalidation_init_early(struct xe_gt *gt)
>  
>  /**
>   * xe_gt_tlb_invalidation_reset - Initialize GT TLB invalidation reset
> - * @gt: graphics tile
> + * @gt: GT structure
>   *
>   * Signal any pending invalidation fences, should be called during a GT reset
>   */
> @@ -244,7 +244,7 @@ static int send_tlb_invalidation(struct xe_guc *guc,
>  
>  /**
>   * xe_gt_tlb_invalidation_guc - Issue a TLB invalidation on this GT for the GuC
> - * @gt: graphics tile
> + * @gt: GT structure
>   * @fence: invalidation fence which will be signal on TLB invalidation
>   * completion
>   *
> @@ -277,7 +277,7 @@ static int xe_gt_tlb_invalidation_guc(struct xe_gt *gt,
>  
>  /**
>   * xe_gt_tlb_invalidation_ggtt - Issue a TLB invalidation on this GT for the GGTT
> - * @gt: graphics tile
> + * @gt: GT structure
>   *
>   * Issue a TLB invalidation for the GGTT. Completion of TLB invalidation is
>   * synchronous.
> @@ -326,7 +326,7 @@ int xe_gt_tlb_invalidation_ggtt(struct xe_gt *gt)
>   * xe_gt_tlb_invalidation_range - Issue a TLB invalidation on this GT for an
>   * address range
>   *
> - * @gt: graphics tile
> + * @gt: GT structure
>   * @fence: invalidation fence which will be signal on TLB invalidation
>   * completion
>   * @start: start address
> @@ -412,7 +412,7 @@ int xe_gt_tlb_invalidation_range(struct xe_gt *gt,
>  
>  /**
>   * xe_gt_tlb_invalidation_vma - Issue a TLB invalidation on this GT for a VMA
> - * @gt: graphics tile
> + * @gt: GT structure
>   * @fence: invalidation fence which will be signal on TLB invalidation
>   * completion, can be NULL
>   * @vma: VMA to invalidate
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine_types.h b/drivers/gpu/drm/xe/xe_hw_engine_types.h
> index e14bee95e3643..e4191a7a2c318 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine_types.h
> +++ b/drivers/gpu/drm/xe/xe_hw_engine_types.h
> @@ -106,7 +106,7 @@ struct xe_hw_engine_class_intf {
>   * Contains all the hardware engine state for physical instances.
>   */
>  struct xe_hw_engine {
> -	/** @gt: graphics tile this hw engine belongs to */
> +	/** @gt: GT structure this hw engine belongs to */
>  	struct xe_gt *gt;
>  	/** @name: name of this hw engine */
>  	const char *name;
> diff --git a/drivers/gpu/drm/xe/xe_hw_fence_types.h b/drivers/gpu/drm/xe/xe_hw_fence_types.h
> index 364a61f4bfda9..58a8d09afe5ca 100644
> --- a/drivers/gpu/drm/xe/xe_hw_fence_types.h
> +++ b/drivers/gpu/drm/xe/xe_hw_fence_types.h
> @@ -41,7 +41,7 @@ struct xe_hw_fence_irq {
>   * to a xe_hw_fence_irq, maintains serial seqno.
>   */
>  struct xe_hw_fence_ctx {
> -	/** @gt: graphics tile of hardware fence context */
> +	/** @gt: GT structure of hardware fence context */
>  	struct xe_gt *gt;
>  	/** @irq: fence irq handler */
>  	struct xe_hw_fence_irq *irq;
> -- 
> 2.47.0
>