Re: [PATCH] drm/xe/guc: Drop error messages about missing GuC logs

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Jan 13, 2025 at 11:44:04AM -0800, John.C.Harrison@Intel.com wrote:
> From: John Harrison <John.C.Harrison@Intel.com>
> 
> The GuC log snapshot code would complain loudly if there was no GuC
> log to take a snapshot of or if the snapshot alloc failed. Originally,
> this code was only called on demand when a user (or developer)
> explicitly requested a dump of the log. Hence an error message was
> useful.
> 
> However, it is now part of the general devcoredump file and is called
> for any GPU hang. Most people don't care about GuC logs and GPU hangs
> do not generally mean a kernel/GuC bug. More importantly, there are
> valid situations where there is no GuC log, e.g. SRIOV VFs.
> 
> So drop the error message.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3958
> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_log.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_log.c b/drivers/gpu/drm/xe/xe_guc_log.c
> index df4cfb698cdb..80151ff6a71f 100644
> --- a/drivers/gpu/drm/xe/xe_guc_log.c
> +++ b/drivers/gpu/drm/xe/xe_guc_log.c
> @@ -149,16 +149,12 @@ struct xe_guc_log_snapshot *xe_guc_log_snapshot_capture(struct xe_guc_log *log,
>  	size_t remain;
>  	int i;
>  
> -	if (!log->bo) {
> -		xe_gt_err(gt, "GuC log buffer not allocated\n");
> +	if (!log->bo)
>  		return NULL;
> -	}
>  
>  	snapshot = xe_guc_log_snapshot_alloc(log, atomic);
> -	if (!snapshot) {
> -		xe_gt_err(gt, "GuC log snapshot not allocated\n");
> +	if (!snapshot)
>  		return NULL;
> -	}
>  
>  	remain = snapshot->size;
>  	for (i = 0; i < snapshot->num_chunks; i++) {
> -- 
> 2.47.0
>