Re: [PATCH] drm/xe: Fix sort order of .o lists in Makefile

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Jan 15, 2025 at 11:08:04AM -0300, Gustavo Sousa wrote:
> The Makefile for xe asks us to keep the lists of object files sorted:
> 
>   # Please keep these build lists sorted!
> 
> Reshuffle the lists into the correct sort order. That was done by
> filtering each unsorted list through 'LC_ALL=C sort'.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
>  drivers/gpu/drm/xe/Makefile | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> index 5c97ad6ed738..34214400b8d1 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -34,8 +34,8 @@ xe-y += xe_bb.o \
>  	xe_dma_buf.o \
>  	xe_drm_client.o \
>  	xe_exec.o \
> -	xe_execlist.o \
>  	xe_exec_queue.o \
> +	xe_execlist.o \
>  	xe_force_wake.o \
>  	xe_ggtt.o \
>  	xe_gpu_scheduler.o \
> @@ -66,11 +66,11 @@ xe-y += xe_bb.o \
>  	xe_guc_pc.o \
>  	xe_guc_submit.o \
>  	xe_heci_gsc.o \
> +	xe_huc.o \
>  	xe_hw_engine.o \
>  	xe_hw_engine_class_sysfs.o \
>  	xe_hw_engine_group.o \
>  	xe_hw_fence.o \
> -	xe_huc.o \
>  	xe_irq.o \
>  	xe_lrc.o \
>  	xe_migrate.o \
> @@ -90,8 +90,8 @@ xe-y += xe_bb.o \
>  	xe_range_fence.o \
>  	xe_reg_sr.o \
>  	xe_reg_whitelist.o \
> -	xe_rtp.o \
>  	xe_ring_ops.o \
> +	xe_rtp.o \
>  	xe_sa.o \
>  	xe_sched_job.o \
>  	xe_step.o \
> @@ -102,8 +102,8 @@ xe-y += xe_bb.o \
>  	xe_trace_bo.o \
>  	xe_trace_guc.o \
>  	xe_trace_lrc.o \
> -	xe_ttm_sys_mgr.o \
>  	xe_ttm_stolen_mgr.o \
> +	xe_ttm_sys_mgr.o \
>  	xe_ttm_vram_mgr.o \
>  	xe_tuning.o \
>  	xe_uc.o \
> @@ -112,8 +112,8 @@ xe-y += xe_bb.o \
>  	xe_vram.o \
>  	xe_vram_freq.o \
>  	xe_vsec.o \
> -	xe_wait_user_fence.o \
>  	xe_wa.o \
> +	xe_wait_user_fence.o \
>  	xe_wopcm.o
>  
>  xe-$(CONFIG_HMM_MIRROR) += xe_hmm.o
> @@ -221,6 +221,7 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
>  	i915-display/intel_display_wa.o \
>  	i915-display/intel_dkl_phy.o \
>  	i915-display/intel_dmc.o \
> +	i915-display/intel_dmc_wl.o \
>  	i915-display/intel_dp.o \
>  	i915-display/intel_dp_aux.o \
>  	i915-display/intel_dp_aux_backlight.o \
> @@ -268,7 +269,6 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \
>  	i915-display/intel_vdsc.o \
>  	i915-display/intel_vga.o \
>  	i915-display/intel_vrr.o \
> -	i915-display/intel_dmc_wl.o \
>  	i915-display/intel_wm.o \
>  	i915-display/skl_scaler.o \
>  	i915-display/skl_universal_plane.o \
> -- 
> 2.48.0
>