Re: [PATCH] drm/xe: Add missing SPDX license identifiers

[Francois Dugast <francois.dugast@intel.com>]

On Thu, Jan 16, 2025 at 08:26:36AM -0600, Lucas De Marchi wrote:
> On Thu, Jan 16, 2025 at 01:45:32PM +0100, Francois Dugast wrote:
> > Ensure all Xe driver files have a proper SPDX license identifier, add it
> > in files where it was missing.
> > 
> > Signed-off-by: Francois Dugast <francois.dugast@intel.com>
> > ---
> > drivers/gpu/drm/xe/Kconfig.profile                           | 1 +
> > drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_stolen.h | 5 +++++
> > 2 files changed, 6 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/xe/Kconfig.profile b/drivers/gpu/drm/xe/Kconfig.profile
> > index ba17a25e8db3..7530df998148 100644
> > --- a/drivers/gpu/drm/xe/Kconfig.profile
> > +++ b/drivers/gpu/drm/xe/Kconfig.profile
> > @@ -1,3 +1,4 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > config DRM_XE_JOB_TIMEOUT_MAX
> > 	int "Default max job timeout (ms)"
> > 	default 10000 # milliseconds
> > diff --git a/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_stolen.h b/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_stolen.h
> > index cb6c7598824b..a1ff59288a3d 100644
> > --- a/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_stolen.h
> > +++ b/drivers/gpu/drm/xe/compat-i915-headers/gem/i915_gem_stolen.h
> > @@ -1,3 +1,8 @@
> > +/* SPDX-License-Identifier: MIT */
> > +/*
> > + * Copyright © 2024 Intel Corporation
> 
> 		^2025
> 
> otherwise,  Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

As this should have been there since initial commit, should we not use
year of file creation according to git log, rather than current year?

Francois

> 
> Lucas De Marchi
> 
> > + */
> > +
> > #ifndef _I915_GEM_STOLEN_H_
> > #define _I915_GEM_STOLEN_H_
> > 
> > -- 
> > 2.43.0
> >