Re: [PATCH] drm/xe/gt_pagefault: Print engine class string

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Jan 29, 2025 at 06:52:41PM +0100, Francois Dugast wrote:
> The engine class index which is printed here is an internal representation
> for debugging. It is _not_ an index based on DRM_XE_ENGINE_CLASS_* values
> provided in the uAPI. Add the string representation of the engine class to
> the output in order to limit possible confusion by users when analyzing the
> logs.
> 
> Signed-off-by: Francois Dugast <francois.dugast@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_gt_pagefault.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.c b/drivers/gpu/drm/xe/xe_gt_pagefault.c
> index 2606cd396df5..cb92fb5cbc75 100644
> --- a/drivers/gpu/drm/xe/xe_gt_pagefault.c
> +++ b/drivers/gpu/drm/xe/xe_gt_pagefault.c
> @@ -263,12 +263,13 @@ static void print_pagefault(struct xe_device *xe, struct pagefault *pf)
>  		 "\tFaultType: %d\n"
>  		 "\tAccessType: %d\n"
>  		 "\tFaultLevel: %d\n"
> -		 "\tEngineClass: %d\n"
> +		 "\tEngineClass: %d %s\n"
>  		 "\tEngineInstance: %d\n",
>  		 pf->asid, pf->vfid, pf->pdata, upper_32_bits(pf->page_addr),
>  		 lower_32_bits(pf->page_addr),
>  		 pf->fault_type, pf->access_type, pf->fault_level,
> -		 pf->engine_class, pf->engine_instance);
> +		 pf->engine_class, xe_hw_engine_class_to_str(pf->engine_class),
> +		 pf->engine_instance);
>  }
>  
>  #define PF_MSG_LEN_DW	4
> -- 
> 2.43.0
>