Re: [PATCH] drm/xe: Skip survivability mode for VF

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Jan 31, 2025 at 08:37:14AM +0000, K V P, Satyanarayana wrote:
> Hi
> > -----Original Message-----
> > From: Tauro, Riana <riana.tauro@intel.com>
> > Sent: Friday, January 31, 2025 1:35 PM
> > To: intel-xe@lists.freedesktop.org
> > Cc: Tauro, Riana <riana.tauro@intel.com>; Gupta, Anshuman
> > <anshuman.gupta@intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>; K V P,
> > Satyanarayana <satyanarayana.k.v.p@intel.com>
> > Subject: [PATCH] drm/xe: Skip survivability mode for VF
> > 
> > Follow the probe flow in case of VF and do not enter survivability mode
> > in case of pcode init failure.
> > 
> > Fixes: 5e940312a2ac ("drm/xe: Add functions and sysfs for boot
> > survivability")
> > Suggested-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
> > Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_survivability_mode.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c
> > b/drivers/gpu/drm/xe/xe_survivability_mode.c
> > index c619560af74f..02b4eadf8407 100644
> > --- a/drivers/gpu/drm/xe/xe_survivability_mode.c
> > +++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
> > @@ -177,7 +177,7 @@ bool xe_survivability_mode_required(struct
> > xe_device *xe)
> >  	struct xe_mmio *mmio = xe_root_tile_mmio(xe);
> >  	u32 data;
> > 
> > -	if (!IS_DGFX(xe) || xe->info.platform < XE_BATTLEMAGE)
> > +	if (!IS_DGFX(xe) || xe->info.platform < XE_BATTLEMAGE ||
> > IS_SRIOV_VF(xe))
> >  		return false;
> > 
> LGTM.
> Reviewed-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>

pushed to drm-xe-next. Thank you both

> >  	data = xe_mmio_read32(mmio, PCODE_SCRATCH(0));
> > --
> > 2.47.1
>