Re: [PATCH 07/14] drm/i915/dp: Move force_dsc_fractional_bpp_en check to intel_dp_dsc_valid_bpp()

[Imre Deak <imre.deak@intel.com>]

On Fri, Jan 31, 2025 at 02:50:00PM +0200, Jani Nikula wrote:
> Add the fractional DSC BPP force check to intel_dp_dsc_valid_bpp(), and
> use that in xelpd_dsc_compute_link_config(). This is another step closer
> towards unifying the platform specific functions.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index ac67f2d2f86a..c7de9efcd740 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -2075,8 +2075,12 @@ static bool intel_dp_dsc_valid_bpp(struct intel_dp *intel_dp, int bpp_x16)
>  	struct intel_display *display = to_intel_display(intel_dp);
>  	int i;
>  
> -	if (DISPLAY_VER(display) >= 13)
> +	if (DISPLAY_VER(display) >= 13) {
> +		if (intel_dp->force_dsc_fractional_bpp_en && !fxp_q4_to_frac(bpp_x16))
> +			return false;
> +
>  		return true;
> +	}
>  
>  	if (fxp_q4_to_frac(bpp_x16))
>  		return false;
> @@ -2143,9 +2147,9 @@ xelpd_dsc_compute_link_config(struct intel_dp *intel_dp,
>  	int ret;
>  
>  	for (bpp_x16 = max_bpp_x16; bpp_x16 >= min_bpp_x16; bpp_x16 -= bpp_step_x16) {
> -		if (intel_dp->force_dsc_fractional_bpp_en &&
> -		    !fxp_q4_to_frac(bpp_x16))
> +		if (!intel_dp_dsc_valid_bpp(intel_dp, bpp_x16))
>  			continue;
> +
>  		ret = dsc_compute_link_config(intel_dp,
>  					      pipe_config,
>  					      limits,
> -- 
> 2.39.5
>