From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
imre.deak@intel.com
Subject: Re: [PATCH 3/3] drm/i915: split out display register macros to a separate file
Date: Wed, 12 Feb 2025 16:45:31 +0200 [thread overview]
Message-ID: <Z6y0C3mX8XyIiZUa@intel.com> (raw)
In-Reply-To: <f6ceecdab92d47e92700b19b278028f0773d71e5.1738935286.git.jani.nikula@intel.com>
On Fri, Feb 07, 2025 at 03:35:22PM +0200, Jani Nikula wrote:
> #define _FPA0 0x6040
> #define _FPA1 0x6044
> #define _FPB0 0x6048
...
> #define _PIPE_MISC2_A 0x7002C
> #define _PIPE_MISC2_B 0x7102C
> #define PIPE_MISC2(pipe) _MMIO_PIPE(pipe, _PIPE_MISC2_A, _PIPE_MISC2_B)
...
> #define _PIPEA_FLIPCOUNT_G4X 0x70044
> #define PIPE_FLIPCOUNT_G4X(dev_priv, pipe) _MMIO_PIPE2(dev_priv, pipe, _PIPEA_FLIPCOUNT_G4X)
...
> #define _PFA_VSCALE 0x68084
> #define _PFB_VSCALE 0x68884
> #define PF_VSCALE(pipe) _MMIO_PIPE(pipe, _PFA_VSCALE, _PFB_VSCALE)
...
> #define HSW_PWR_WELL_CTL5 _MMIO(0x45410)
> #define HSW_PWR_WELL_ENABLE_SINGLE_STEP (1 << 31)
This approach seems to leave quite a lot of stuff behind.
I'm just wondering how painful it'll be to find the right spot
for those again after the fact...
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2025-02-12 14:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 13:35 [PATCH 0/3] drm/i915: i915_reg.h display split Jani Nikula
2025-02-07 13:35 ` [PATCH 1/3] drm/i915/reg: use REG_BIT and friends to define DP registers Jani Nikula
2025-02-12 8:07 ` Kandpal, Suraj
2025-02-12 9:39 ` Jani Nikula
2025-02-12 12:42 ` Kandpal, Suraj
2025-02-07 13:35 ` [PATCH 2/3] drm/i915/reg: Remove some extra blank lines Jani Nikula
2025-02-12 8:07 ` Kandpal, Suraj
2025-02-07 13:35 ` [PATCH 3/3] drm/i915: split out display register macros to a separate file Jani Nikula
2025-02-12 8:48 ` Kandpal, Suraj
2025-02-12 9:41 ` Jani Nikula
2025-02-12 14:45 ` Ville Syrjälä [this message]
2025-02-12 15:12 ` Ville Syrjälä
2025-02-12 16:49 ` Jani Nikula
2025-02-07 16:47 ` ✓ CI.Patch_applied: success for drm/i915: i915_reg.h display split Patchwork
2025-02-07 16:48 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-07 16:49 ` ✓ CI.KUnit: success " Patchwork
2025-02-07 17:05 ` ✓ CI.Build: " Patchwork
2025-02-07 17:08 ` ✓ CI.Hooks: " Patchwork
2025-02-07 17:09 ` ✓ CI.checksparse: " Patchwork
2025-02-07 17:31 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-08 4:09 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6y0C3mX8XyIiZUa@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox