Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	jani.nikula@linux.intel.com,
	mitulkumar.ajitkumar.golani@intel.com
Subject: Re: [PATCH 10/20] drm/i915/dp_mst: Use VRR Timing generator for DP MST
Date: Wed, 26 Feb 2025 15:30:54 +0200	[thread overview]
Message-ID: <Z78Xjoj23jhIbIQG@intel.com> (raw)
In-Reply-To: <20250224061717.1095226-11-ankit.k.nautiyal@intel.com>

On Mon, Feb 24, 2025 at 11:47:07AM +0530, Ankit Nautiyal wrote:
> Configure VRR timing generator for DP MST for fixed refresh rate.
> Currently the variable timings are supported only for DP and eDP and not
> for DP MST. Call intel_vrr_compute_config for MST which will configure
> fixed refresh rate timings irrespective of whether VRR is supported or
> not.

Also needs actual justification like the HDMI version.

> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 167e4a70ab12..2c4a9ac6f61e 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -51,6 +51,7 @@
>  #include "intel_link_bw.h"
>  #include "intel_psr.h"
>  #include "intel_vdsc.h"
> +#include "intel_vrr.h"
>  #include "skl_scaler.h"
>  
>  /*
> @@ -709,6 +710,8 @@ static int mst_stream_compute_config(struct intel_encoder *encoder,
>  		pipe_config->lane_lat_optim_mask =
>  			bxt_dpio_phy_calc_lane_lat_optim_mask(pipe_config->lane_count);
>  
> +	intel_vrr_compute_config(pipe_config, conn_state);
> +
>  	intel_dp_audio_compute_config(encoder, pipe_config, conn_state);
>  
>  	intel_ddi_compute_min_voltage_level(pipe_config);
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2025-02-26 13:31 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-24  6:16 [PATCH 00/20] Use VRR timing generator for fixed refresh rate modes Ankit Nautiyal
2025-02-24  6:16 ` [PATCH 01/20] drm/i915/vrr: Remove unwanted comment Ankit Nautiyal
2025-02-26 13:06   ` Ville Syrjälä
2025-02-24  6:16 ` [PATCH 02/20] drm/i915:vrr: Separate out functions to compute vmin and vmax Ankit Nautiyal
2025-02-26 12:59   ` Ville Syrjälä
2025-02-27 10:13     ` Nautiyal, Ankit K
2025-02-24  6:17 ` [PATCH 03/20] drm/i915/vrr: Make helpers for cmrr and vrr timings Ankit Nautiyal
2025-02-26 13:07   ` Ville Syrjälä
2025-02-24  6:17 ` [PATCH 04/20] drm/i915/vrr: Disable CMRR Ankit Nautiyal
2025-02-26 13:08   ` Ville Syrjälä
2025-02-24  6:17 ` [PATCH 05/20] drm/i915/vrr: Track vrr.enable only for variable timing Ankit Nautiyal
2025-02-26 13:10   ` Ville Syrjälä
2025-02-27 10:16     ` Nautiyal, Ankit K
2025-02-24  6:17 ` [PATCH 06/20] drm/i915/vrr: Use crtc_vtotal for vmin Ankit Nautiyal
2025-02-26 13:11   ` Ville Syrjälä
2025-02-24  6:17 ` [PATCH 07/20] drm/i915/vrr: Prepare for fixed refresh rate timings Ankit Nautiyal
2025-02-26 13:13   ` Ville Syrjälä
2025-02-24  6:17 ` [PATCH 08/20] drm/i915/display: Enable MSA Ignore Timing PAR only when in not fixed_rr mode Ankit Nautiyal
2025-02-26 13:27   ` Ville Syrjälä
2025-02-27 10:19     ` Nautiyal, Ankit K
2025-02-24  6:17 ` [PATCH 09/20] drm/i915/hdmi: Use VRR Timing generator for HDMI Ankit Nautiyal
2025-02-26 13:30   ` Ville Syrjälä
2025-02-27 10:31     ` Nautiyal, Ankit K
2025-02-24  6:17 ` [PATCH 10/20] drm/i915/dp_mst: Use VRR Timing generator for DP MST Ankit Nautiyal
2025-02-26 13:30   ` Ville Syrjälä [this message]
2025-02-24  6:17 ` [PATCH 11/20] drm/i915/display: Disable PSR before disabling VRR Ankit Nautiyal
2025-02-26 13:45   ` Ville Syrjälä
2025-02-27 10:33     ` Nautiyal, Ankit K
2025-02-24  6:17 ` [PATCH 12/20] drm/i915/display: Extend WA 14015406119 for PSR2 Ankit Nautiyal
2025-02-26 13:55   ` Ville Syrjälä
2025-02-27 10:36     ` Nautiyal, Ankit K
2025-02-24  6:17 ` [PATCH 13/20] drm/i915/vrr: Handle joiner with vrr Ankit Nautiyal
2025-02-24 13:47   ` Nautiyal, Ankit K
2025-02-26 15:14     ` Ville Syrjälä
2025-02-27 10:37       ` Nautiyal, Ankit K
2025-02-24  6:17 ` [PATCH 14/20] drm/i915/vrr: Refactor condition for computing vmax and LRR Ankit Nautiyal
2025-02-26 14:01   ` Ville Syrjälä
2025-02-27 10:39     ` Nautiyal, Ankit K
2025-02-24  6:17 ` [PATCH 15/20] drm/i915/vrr: Always set vrr vmax/vmin/flipline in vrr_{enable/disable} Ankit Nautiyal
2025-02-26 14:01   ` Ville Syrjälä
2025-02-24  6:17 ` [PATCH 16/20] drm/i915/display: Use fixed rr timings in intel_set_transcoder_timings_lrr() Ankit Nautiyal
2025-02-26 15:00   ` Ville Syrjälä
2025-02-27 10:28     ` Nautiyal, Ankit K
2025-02-24  6:17 ` [PATCH 17/20] drm/i915/display: Use fixed_rr timings in modeset sequence Ankit Nautiyal
2025-02-26 15:06   ` Ville Syrjälä
2025-02-26 16:04     ` Ville Syrjälä
2025-02-27 10:44       ` Nautiyal, Ankit K
2025-02-27 10:42     ` Nautiyal, Ankit K
2025-02-24  6:17 ` [PATCH 18/20] drm/i915/vrr: Use fixed timings for platforms that support VRR Ankit Nautiyal
2025-02-26 15:11   ` Ville Syrjälä
2025-02-27 11:01     ` Nautiyal, Ankit K
2025-02-27 21:05       ` Ville Syrjälä
2025-02-28 12:31         ` Nautiyal, Ankit K
2025-02-24  6:17 ` [PATCH 19/20] drm/i915/vrr: Always use VRR timing generator for MTL+ Ankit Nautiyal
2025-02-24  6:17 ` [PATCH 20/20] drm/i915/display: Add fixed_rr to crtc_state dump Ankit Nautiyal
2025-02-24 17:59 ` ✓ CI.Patch_applied: success for Use VRR timing generator for fixed refresh rate modes (rev5) Patchwork
2025-02-24 17:59 ` ✓ CI.checkpatch: " Patchwork
2025-02-24 18:00 ` ✓ CI.KUnit: " Patchwork
2025-02-24 18:17 ` ✓ CI.Build: " Patchwork
2025-02-24 18:19 ` ✓ CI.Hooks: " Patchwork
2025-02-24 18:21 ` ✗ CI.checksparse: warning " Patchwork
2025-02-24 18:39 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-24 20:03 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z78Xjoj23jhIbIQG@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=mitulkumar.ajitkumar.golani@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox