From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6DB9C021A9 for ; Mon, 17 Feb 2025 17:49:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 922A010E57C; Mon, 17 Feb 2025 17:49:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="KrUwd67e"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id C2FE610E57C; Mon, 17 Feb 2025 17:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739814552; x=1771350552; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ZNATdTqjQ+loYzJim7LSp7kE7rh1rWSBGozUlt9Skcw=; b=KrUwd67ey5Kgh/zpevJQgSPKiffm+FLgPO0A+Vlfwh3y5hzKLvFwVVoG s7U1cp6mB4POu2a0vYJlD3/Was2eLbPi65nOqQMKQZyErSqNYhRU1lLkp PTiO+8gtPtF6R1JlIwWWUJulNGy3wjUNH1W+gI4aFB9mH6qyint/if4hx HYGspf5jL/kSMJzsbUjxO0Pd8j1aWjCnEiakvE57HXT8MX5JxEqLzcEQ6 uSRM1TLHcZx3VV3VV9x2aRBIzx5cg0ekDhF5gLLiWEl6P7sGmAz8xH0hw eILQqoj8Ohyx0TpFGVQco/Q95HsrFOtE7B1NfibmAT5Ue9flxoRrIoOK9 g==; X-CSE-ConnectionGUID: aGGcnYazTjWoLB5Wp0WCMA== X-CSE-MsgGUID: 1mVBtluXS/2W6uPwobHJWg== X-IronPort-AV: E=McAfee;i="6700,10204,11348"; a="40210798" X-IronPort-AV: E=Sophos;i="6.13,293,1732608000"; d="scan'208";a="40210798" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2025 09:49:11 -0800 X-CSE-ConnectionGUID: bnqaCB6STZ2hmFvv1u4HUg== X-CSE-MsgGUID: kUDONHIhSvi77eKn44J4HQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,293,1732608000"; d="scan'208";a="114378807" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by fmviesa008.fm.intel.com with SMTP; 17 Feb 2025 09:49:09 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 17 Feb 2025 19:49:08 +0200 Date: Mon, 17 Feb 2025 19:49:08 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Gustavo Sousa Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v2 2/3] drm/i915/display: Use display-specific platform checks in intel_bw.c Message-ID: References: <20250217153550.43909-1-gustavo.sousa@intel.com> <20250217153550.43909-3-gustavo.sousa@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250217153550.43909-3-gustavo.sousa@intel.com> X-Patchwork-Hint: comment X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, Feb 17, 2025 at 12:35:24PM -0300, Gustavo Sousa wrote: > Add one step further into making intel_bw.c xe/i915 agnostic by using > display-specific platform checks. > > v2: > - Fix typo that resulted in converting IS_DG1(display) to > display->platform.dg2. > > Signed-off-by: Gustavo Sousa > --- > drivers/gpu/drm/i915/display/intel_bw.c | 77 ++++++++++++++----------- > 1 file changed, 43 insertions(+), 34 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c > index 0fb41e6cd8ae..51b82979a8e4 100644 > --- a/drivers/gpu/drm/i915/display/intel_bw.c > +++ b/drivers/gpu/drm/i915/display/intel_bw.c > @@ -78,6 +78,7 @@ static int icl_pcode_read_qgv_point_info(struct drm_i915_private *dev_priv, > struct intel_qgv_point *sp, > int point) > { > + struct intel_display *display = &dev_priv->display; > u32 val = 0, val2 = 0; > u16 dclk; > int ret; > @@ -89,7 +90,7 @@ static int icl_pcode_read_qgv_point_info(struct drm_i915_private *dev_priv, > return ret; > > dclk = val & 0xffff; > - sp->dclk = DIV_ROUND_UP((16667 * dclk) + (DISPLAY_VER(dev_priv) >= 12 ? 500 : 0), > + sp->dclk = DIV_ROUND_UP((16667 * dclk) + (DISPLAY_VER(display) >= 12 ? 500 : 0), Side note: could you (or someone) fix up this botched rounding stuff? -- Ville Syrjälä Intel