From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B911DC282D1 for ; Thu, 6 Mar 2025 08:57:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F0A510E920; Thu, 6 Mar 2025 08:57:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Av9ctsva"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4F9B10E922 for ; Thu, 6 Mar 2025 08:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741251457; x=1772787457; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=GOMBHrWqTMOLlkBk6hFKtkLzwQHxO3UhK3n6qUZTCGY=; b=Av9ctsva9ZI9t1gHLe/rfDEW2zjhm9a7h7Qh/dwAHPagQNIVHR8/PHPN COKlbWJCJj/1tLuS4N/0FSD8LwDLz35ac+IedRUn9i2Zp8/EW2tMNnsd1 Gxwcmv8a7XGa+ZZdfseewQoUo1T4H4RIJh9mWaa2Lp3xgpaiMIbt9zIfq +hi1F8OuCBxmsmZUbcJNmVmctmYBCPMUCo/tE/2oLJqv64TxcXqy2ubIc PEusYxu66SI5Wy9uCMyX4T2djLHntq436kiOxfS1Ljv2arpZCbSVpkKAT cUYuA383n4aOzGFW/Im6HWU5GyT3PlzwyrOs+ngw9ph/X2Tgul/Ob4o1P Q==; X-CSE-ConnectionGUID: r9QETzWMR6SiXQHMggo7Kg== X-CSE-MsgGUID: RdJlEuDITTSgZIu9TVvllw== X-IronPort-AV: E=McAfee;i="6700,10204,11363"; a="53648430" X-IronPort-AV: E=Sophos;i="6.14,225,1736841600"; d="scan'208";a="53648430" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2025 00:57:35 -0800 X-CSE-ConnectionGUID: Vxgcah0eROaLGDrB86cqZw== X-CSE-MsgGUID: Q366Cqm4RMG2byj2dGXoFA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,225,1736841600"; d="scan'208";a="142186747" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Mar 2025 00:57:34 -0800 Date: Thu, 6 Mar 2025 10:57:30 +0200 From: Raag Jadav To: Aravind Iddamsetty Cc: lucas.demarchi@intel.com, rodrigo.vivi@intel.com, anshuman.gupta@intel.com, badal.nilawar@intel.com, riana.tauro@intel.com, intel-xe@lists.freedesktop.org Subject: Re: [PATCH v1] drm/xe/pcode: stop logging mailbox status as error Message-ID: References: <20250304061727.452100-1-raag.jadav@intel.com> <29d173b4-4cac-4765-a13e-8723b44f5270@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29d173b4-4cac-4765-a13e-8723b44f5270@linux.intel.com> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, Mar 06, 2025 at 10:08:07AM +0530, Aravind Iddamsetty wrote: > Hi Raag, > > On 04-03-2025 11:47, Raag Jadav wrote: > > Since we're expecting many platform specific mailbox commands that > > might not be widely supported, stop logging them as errors. With this > > we can avoid unnecessary platform checks and use the return value of > > mailbox without enraging CI. > are you saying there are cases where we send a command that is not supported > on a particular platform? Yes. First instance on [1], which will be expanded with more commands. [1] https://lore.kernel.org/r/20250210100515.2205584-1-raag.jadav@intel.com/ > > Signed-off-by: Raag Jadav > > --- > > drivers/gpu/drm/xe/xe_pcode.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/xe/xe_pcode.c b/drivers/gpu/drm/xe/xe_pcode.c > > index 9333ce776a6e..280f69119ff1 100644 > > --- a/drivers/gpu/drm/xe/xe_pcode.c > > +++ b/drivers/gpu/drm/xe/xe_pcode.c > > @@ -46,7 +46,7 @@ static int pcode_mailbox_status(struct xe_tile *tile) > > > > err = xe_mmio_read32(&tile->mmio, PCODE_MAILBOX) & PCODE_ERROR_MASK; > > if (err) { > > - drm_err(&tile_to_xe(tile)->drm, "PCODE Mailbox failed: %d %s", err, > > + drm_dbg(&tile_to_xe(tile)->drm, "PCODE Mailbox failed: %d %s", err, > > err_decode[err].str ?: "Unknown"); > > return err_decode[err].errno ?: -EPROTO; > > }