From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 502ECC19F32 for ; Fri, 7 Mar 2025 13:30:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 005C010EB43; Fri, 7 Mar 2025 13:30:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; secure) header.d=ffwll.ch header.i=@ffwll.ch header.b="AiDg1B8c"; dkim-atps=neutral Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9CB5810EB4E for ; Fri, 7 Mar 2025 13:30:01 +0000 (UTC) Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3910e101d0fso1018966f8f.2 for ; Fri, 07 Mar 2025 05:30:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1741354200; x=1741959000; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=ekE5xsi6ZfzsstIFHcXwKSB/c+BLxZ8NF8WHZmG2dto=; b=AiDg1B8ctRnoS6AxfhaZ/WbNdrUZWxa9KR4vwyVhtDu6kphPDa0b2foAEPa8z2vzwW 9KeEn/c0+/LZdiKRgw7o0IQYh+STofzbq1WDMzc/HC7X6VpllUhAUPnemXwsYYV4QoHU Ocl3dQj2inaEu2MvrRzb4iwYfb5pvH/k9SV14= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741354200; x=1741959000; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ekE5xsi6ZfzsstIFHcXwKSB/c+BLxZ8NF8WHZmG2dto=; b=EKbI/X40Y9+Uvzmmm4SjE+iUqZZUB9nAVwdhu0kYXLkoPUCY5CVuN02H6qkl7pomYf 0rx8dmeM3f88FSB4hYjYdngoeDKQFGjY/ysp6KcTMZzGiydve6mxdMZFmlXDcWEQSOQt Rnsb/uIBlvcKdzClregDO/3c0fid0LMdMt+Ct/2J3HbG8Ueb9D18ZFg98fUUujVdPTiK 9Cp88HcosECUQHrr4sKd2URFhdzao0lZN7vcFo7YrShsgF+hHiccB9tK0ZPyx/gZX9bt 5CRQorPzpNQvZvsYYy3YRZfB7z4q/cNIMxWCylXBfFWHfTqG0hpfdIsHKONkFf9NEk5c sZYQ== X-Forwarded-Encrypted: i=1; AJvYcCUbA1GMu3cgrZ2nGZWzBdqsH97nzIfT8zwKX5Rq4TlGG65XpGpOFCiwTj9jMNITn8tONmCbVdsQjw==@lists.freedesktop.org X-Gm-Message-State: AOJu0YwV4IkkvdiqKykJvD2tjCi7veLT99pVMSn+qc/pNt0Ms7g1LNT1 i7d8QdO+ok2lE3fAcVImhExiCMLdSimxYmzXI63W6zBioMDdaSBi1Uk72wQUAto= X-Gm-Gg: ASbGncvHR9Oqp9BtaPqzg67c2zJMNjWR3Jtdr++vhYnQwBlEnwC7VOXIa1qYKydJwFt OfgAOCv6VYUYEu4hNxXx01JmtNTtTmPO0lyrk58OyEeM9nO+THoywWkU+YZSjYq8wBtmzJ3380a 1AHuXE4pzFOfdBn6VQLj9huzZGoO8jH9R0rHcEIDASLJmjkQR+73dkoGuG22a/BSaUjVpbZBoAk cOX1fthrOzmqdJCMPlpG6rVoV/ukLuRLRXCHwsGwaexTj3n2DGtuDWPPrjK73995BF1KLoHKW7p 1byJvMvjaDhLHfq7n/5j0XMaEL2TuQCMwbPb4xYCWVdHSmWSbt+e4kdy X-Google-Smtp-Source: AGHT+IH/kkCP3WG8+wzNo7ysyBh/OLARokHFUAgPdG9FvCx5V4btdPhz7YMsZxr6IpgW9UUP3aP3IA== X-Received: by 2002:a05:6000:144d:b0:38f:3a89:fdb5 with SMTP id ffacd0b85a97d-39132d244fdmr2005477f8f.11.1741354199959; Fri, 07 Mar 2025 05:29:59 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:5485:d4b2:c087:b497]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bdd8b0425sm51891245e9.3.2025.03.07.05.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 05:29:59 -0800 (PST) Date: Fri, 7 Mar 2025 14:29:57 +0100 From: Simona Vetter To: Dmitry Baryshkov Cc: Lyude Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Jani Nikula , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Jani Nikula Subject: Re: [PATCH RFC v3 0/7] drm/display: dp: add new DPCD access functions Message-ID: Mail-Followup-To: Dmitry Baryshkov , Lyude Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Jani Nikula , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Jani Nikula References: <20250307-drm-rework-dpcd-access-v3-0-9044a3a868ee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250307-drm-rework-dpcd-access-v3-0-9044a3a868ee@linaro.org> X-Operating-System: Linux phenom 6.12.11-amd64 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, Mar 07, 2025 at 06:34:42AM +0200, Dmitry Baryshkov wrote: > Existing DPCD access functions return an error code or the number of > bytes being read / write in case of partial access. However a lot of > drivers either (incorrectly) ignore partial access or mishandle error > codes. In other cases this results in a boilerplate code which compares > returned value with the size. > > As suggested by Jani implement new set of DPCD access helpers, which > ignore partial access, always return 0 or an error code. Implement > new helpers using existing functions to ensure backwards compatibility > and to assess necessity to handle incomplete reads on a global scale. > Currently only one possible place has been identified, dp-aux-dev, which > needs to handle possible holes in DPCD. > > This series targets only the DRM helpers code. If the approach is found > to be acceptable, each of the drivers should be converted on its own. > > Signed-off-by: Dmitry Baryshkov Just wanted to drop my "I like this" on your series here. Short read/writes come from unix pipes, and they're everywhere, and yes ime everyone gets them wrong. So ack or whatever that means :-) -Sima > --- > Changes in v3: > - Fixed cover letter (Jani) > - Added intel-gfx and intel-xe to get the series CI-tested (Jani) > - Link to v2: https://lore.kernel.org/r/20250301-drm-rework-dpcd-access-v2-0-4d92602fc7cd@linaro.org > > Changes in v2: > - Reimplemented new helpers using old ones (Lyude) > - Reworked the drm_dp_dpcd_read_link_status() patch (Lyude) > - Dropped the dp-aux-dev patch (Jani) > - Link to v1: https://lore.kernel.org/r/20250117-drm-rework-dpcd-access-v1-0-7fc020e04dbc@linaro.org > > --- > Dmitry Baryshkov (7): > drm/display: dp: implement new access helpers > drm/display: dp: change drm_dp_dpcd_read_link_status() return value > drm/display: dp: use new DCPD access helpers > drm/display: dp-aux-dev: use new DCPD access helpers > drm/display: dp-cec: use new DCPD access helpers > drm/display: dp-mst-topology: use new DCPD access helpers > drm/display: dp-tunnel: use new DCPD access helpers > > drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 8 +- > .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 2 +- > drivers/gpu/drm/display/drm_dp_aux_dev.c | 12 +- > drivers/gpu/drm/display/drm_dp_cec.c | 37 ++- > drivers/gpu/drm/display/drm_dp_helper.c | 307 +++++++++------------ > drivers/gpu/drm/display/drm_dp_mst_topology.c | 105 ++++--- > drivers/gpu/drm/display/drm_dp_tunnel.c | 20 +- > drivers/gpu/drm/hisilicon/hibmc/dp/dp_link.c | 4 +- > drivers/gpu/drm/msm/dp/dp_ctrl.c | 24 +- > drivers/gpu/drm/msm/dp/dp_link.c | 18 +- > drivers/gpu/drm/radeon/atombios_dp.c | 8 +- > include/drm/display/drm_dp_helper.h | 92 +++++- > 12 files changed, 322 insertions(+), 315 deletions(-) > --- > base-commit: 565351ae7e0cee80e9b5ed84452a5b13644ffc4d > change-id: 20241231-drm-rework-dpcd-access-b0fc2e47d613 > > Best regards, > -- > Dmitry Baryshkov > -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch