Re: [PATCH 07/11] drm/i915/dpll: Change argument for enable hook in intel_global_dpll_funcs

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Feb 25, 2025 at 01:39:23PM +0530, Suraj Kandpal wrote:
> Change the arguments for enable hook in intel_global_dpll_funcs to only
> accept crtc_state. This is because we really don't need those extra
> arguments everything can be derived from crtc_state and we need
> intel_encoder for PLL enablement when DISPLAY_VER() >= 14.
> 
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 100 ++++++++++--------
>  1 file changed, 54 insertions(+), 46 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index bd623fdddfdc..c39f7d73a89f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -66,9 +66,8 @@ struct intel_global_dpll_funcs {
>  	 * Hook for enabling the pll, called from intel_enable_global_dpll() if
>  	 * the pll is not already enabled.
>  	 */
> -	void (*enable)(struct intel_display *display,
> -		       struct intel_global_dpll *pll,
> -		       const struct intel_dpll_hw_state *dpll_hw_state);
> +	void (*enable)(const struct intel_crtc_state *state,

This feels like the wrong direction. We want the plls to be
independent of crtcs. The crtc_state should only be necessary
to compute a plls's state.

-- 
Ville Syrjälä
Intel