From: Matthew Brost <matthew.brost@intel.com>
To: Maarten Lankhorst <dev@lankhorst.se>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/xe: Remove extra spaces in xe_vm.c
Date: Thu, 20 Mar 2025 14:45:18 -0700 [thread overview]
Message-ID: <Z9yMbpMle5PF1k+H@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20250320211519.632432-1-dev@lankhorst.se>
On Thu, Mar 20, 2025 at 10:15:18PM +0100, Maarten Lankhorst wrote:
Probably add commit message.
With that:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 3dbd3d38008a5..fed4b97d1882d 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2980,7 +2980,7 @@ static int xe_vm_bind_ioctl_validate_bo(struct xe_device *xe, struct xe_bo *bo,
> XE_64K_PAGE_MASK) ||
> XE_IOCTL_DBG(xe, addr & XE_64K_PAGE_MASK) ||
> XE_IOCTL_DBG(xe, range & XE_64K_PAGE_MASK)) {
> - return -EINVAL;
> + return -EINVAL;
> }
> }
>
> @@ -2988,7 +2988,7 @@ static int xe_vm_bind_ioctl_validate_bo(struct xe_device *xe, struct xe_bo *bo,
> if (bo->cpu_caching) {
> if (XE_IOCTL_DBG(xe, coh_mode == XE_COH_NONE &&
> bo->cpu_caching == DRM_XE_GEM_CPU_CACHING_WB)) {
> - return -EINVAL;
> + return -EINVAL;
> }
> } else if (XE_IOCTL_DBG(xe, coh_mode == XE_COH_NONE)) {
> /*
> @@ -2997,7 +2997,7 @@ static int xe_vm_bind_ioctl_validate_bo(struct xe_device *xe, struct xe_bo *bo,
> * how it was mapped on the CPU. Just assume is it
> * potentially cached on CPU side.
> */
> - return -EINVAL;
> + return -EINVAL;
> }
>
> /* If a BO is protected it can only be mapped if the key is still valid */
> --
> 2.45.2
>
next prev parent reply other threads:[~2025-03-20 21:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 21:15 [PATCH 1/2] drm/xe: Remove extra spaces in xe_vm.c Maarten Lankhorst
2025-03-20 21:15 ` [PATCH 2/2] drm/xe: Copy cpu_caching when importing DMA-BUF Maarten Lankhorst
2025-03-21 0:23 ` Matthew Brost
2025-03-21 10:23 ` Thomas Hellström
2025-03-25 8:10 ` Maarten Lankhorst
2025-03-20 21:45 ` Matthew Brost [this message]
2025-03-20 22:01 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe: Remove extra spaces in xe_vm.c Patchwork
2025-03-20 22:01 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-20 22:02 ` ✓ CI.KUnit: success " Patchwork
2025-03-20 22:19 ` ✓ CI.Build: " Patchwork
2025-03-20 22:21 ` ✓ CI.Hooks: " Patchwork
2025-03-20 22:30 ` ✓ CI.checksparse: " Patchwork
2025-03-21 5:43 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-25 8:55 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe: Remove extra spaces in xe_vm.c (rev2) Patchwork
2025-03-25 8:55 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-25 8:56 ` ✓ CI.KUnit: success " Patchwork
2025-03-25 9:13 ` ✓ CI.Build: " Patchwork
2025-03-25 9:15 ` ✓ CI.Hooks: " Patchwork
2025-03-25 9:16 ` ✓ CI.checksparse: " Patchwork
2025-03-25 9:37 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-03-25 10:41 ` Maarten Lankhorst
2025-03-25 13:41 ` Matthew Auld
2025-03-25 19:05 ` Thomas Hellström
2025-03-26 17:51 ` Matthew Auld
2025-03-25 15:12 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9yMbpMle5PF1k+H@lstrano-desk.jf.intel.com \
--to=matthew.brost@intel.com \
--cc=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox