From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Chang, Bruce" <yu.bruce.chang@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH] drm/xe: follow up on the patch to fix pvc unload issue
Date: Wed, 5 Apr 2023 13:28:30 -0400 [thread overview]
Message-ID: <ZC2vvhhbSJwSRUWk@intel.com> (raw)
In-Reply-To: <20230405171303.525412-1-yu.bruce.chang@intel.com>
On Wed, Apr 05, 2023 at 05:13:03PM +0000, Chang, Bruce wrote:
> created xe_ttm_sys_mgr.h as suggested by Lucas
> also fixed a compile warning found by Lucas
>
> v2: fix a comment format issue
>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Bruce Chang <yu.bruce.chang@intel.com>
I pushed this patch to drm-xe-next but as a fixup! for the
original. So it will get autosquashed on our next cleanup rebase.
> ---
> drivers/gpu/drm/xe/xe_device.c | 1 +
> drivers/gpu/drm/xe/xe_device.h | 1 -
> drivers/gpu/drm/xe/xe_ttm_sys_mgr.c | 1 +
> drivers/gpu/drm/xe/xe_ttm_sys_mgr.h | 13 +++++++++++++
> 4 files changed, 15 insertions(+), 1 deletion(-)
> create mode 100644 drivers/gpu/drm/xe/xe_ttm_sys_mgr.h
>
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 4fb9aff27686..85caf81ae686 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -27,6 +27,7 @@
> #include "xe_pcode.h"
> #include "xe_pm.h"
> #include "xe_query.h"
> +#include "xe_ttm_sys_mgr.h"
> #include "xe_ttm_stolen_mgr.h"
> #include "xe_vm.h"
> #include "xe_vm_madvise.h"
> diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
> index d9d1b09a8e38..d277f8985f7b 100644
> --- a/drivers/gpu/drm/xe/xe_device.h
> +++ b/drivers/gpu/drm/xe/xe_device.h
> @@ -116,5 +116,4 @@ static inline bool xe_device_has_flat_ccs(struct xe_device *xe)
> }
>
> u32 xe_device_ccs_bytes(struct xe_device *xe, u64 size);
> -int xe_ttm_sys_mgr_init(struct xe_device *xe);
> #endif
> diff --git a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c
> index cf5f4f73d4dc..9c2f7d4936d8 100644
> --- a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c
> +++ b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c
> @@ -12,6 +12,7 @@
>
> #include "xe_bo.h"
> #include "xe_gt.h"
> +#include "xe_ttm_sys_mgr.h"
>
> struct xe_ttm_sys_node {
> struct ttm_buffer_object *tbo;
> diff --git a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.h b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.h
> new file mode 100644
> index 000000000000..2f27d9117b54
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.h
> @@ -0,0 +1,13 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2022 Intel Corporation
> + */
> +
> +#ifndef _XE_TTM_SYS_MGR_H_
> +#define _XE_TTM_SYS_MGR_H_
> +
> +struct xe_device;
> +
> +int xe_ttm_sys_mgr_init(struct xe_device *xe);
> +
> +#endif
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-04-05 17:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 17:13 [Intel-xe] [PATCH] drm/xe: follow up on the patch to fix pvc unload issue Chang, Bruce
2023-04-05 17:28 ` [Intel-xe] ✓ CI.Patch_applied: success for drm/xe: follow up on the patch to fix pvc unload issue (rev2) Patchwork
2023-04-05 17:28 ` Rodrigo Vivi [this message]
2023-04-05 17:29 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-04-05 17:29 ` [Intel-xe] [PATCH] drm/xe: follow up on the patch to fix pvc unload issue Lucas De Marchi
2023-04-05 17:33 ` [Intel-xe] ✓ CI.Build: success for drm/xe: follow up on the patch to fix pvc unload issue (rev2) Patchwork
2023-04-05 17:44 ` [Intel-xe] ○ CI.BAT: info " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-04-05 17:08 [Intel-xe] [PATCH] drm/xe: follow up on the patch to fix pvc unload issue Chang, Bruce
2023-04-05 17:28 ` Lucas De Marchi
2023-04-05 18:14 ` Chang, Yu bruce
2023-04-05 18:29 ` Lucas De Marchi
2023-04-05 19:52 ` Chang, Yu bruce
2023-04-06 19:20 ` Rodrigo Vivi
2023-04-06 20:06 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC2vvhhbSJwSRUWk@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=yu.bruce.chang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox