Re: [Intel-xe] [PATCH v2 rebased 5/6] drm/xe/display: Disable PSR HW tracking for DG2 and MTL

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Apr 06, 2023 at 07:31:32AM -0700, José Roberto de Souza wrote:
> Of the platforms supported by Xe, only TGL and DG1 has PSR HW
> tracking.

so, it looks like what we want is something like

diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
index 5fab5b9fbde0..3c05d51630f2 100644
--- a/drivers/gpu/drm/xe/xe_display.c
+++ b/drivers/gpu/drm/xe/xe_display.c
@@ -446,7 +446,7 @@ __diag_ignore_all("-Woverride-init", "Allow field overrides in table");
        .has_hdcp = 1,                                                  \
        .has_ipc = 1,                                                   \
        .has_psr = 1,                                                   \
-       .has_psr_hw_tracking = 1,                                       \
+       .has_psr_hw_tracking = 0,                                       \
        .color = { .degamma_lut_size = 33, .gamma_lut_size = 262145 }
 
 #define XE_LPD                                                         \
@@ -486,13 +486,15 @@ void xe_display_info_init(struct xe_device *xe)
        switch (xe->info.platform) {
        case XE_TIGERLAKE:
        case XE_DG1:
-               xe->info.display = (struct xe_device_display_info) { GEN12_DISPLAY };
+               xe->info.display = (struct xe_device_display_info) {
+                       GEN12_DISPLAY,
+                       .has_psr_hw_tracking = 1,
+               };
                break;
        case XE_ALDERLAKE_S:
                xe->info.display = (struct xe_device_display_info) {
                        GEN12_DISPLAY,
                        .has_hti = 1,
-                       .has_psr_hw_tracking = 0,
                };
                break;
        case XE_ALDERLAKE_P:
@@ -500,7 +502,6 @@ void xe_display_info_init(struct xe_device *xe)
                        XE_LPD,
                        .has_cdclk_crawl = 1,
                        .has_modular_fia = 1,
-                       .has_psr_hw_tracking = 0,
                };
                break;
:


> 
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_display.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
> index 0001a9d02495d..edbc88500ed1e 100644
> --- a/drivers/gpu/drm/xe/xe_display.c
> +++ b/drivers/gpu/drm/xe/xe_display.c
> @@ -469,7 +469,8 @@ __diag_ignore_all("-Woverride-init", "Allow field overrides in table");
>  	.has_fpga_dbg = 1,						\
>  	.has_hdcp = 1,							\
>  	.has_ipc = 1,							\
> -	.has_psr = 1
> +	.has_psr = 1,							\
> +	.has_psr_hw_tracking = 0
>  
>  #define XE_LPDP								\
>  	XE_LPD,								\
> @@ -502,8 +503,7 @@ void xe_display_info_init(struct xe_device *xe)
>  		xe->info.display = (struct xe_device_display_info) {
>  			XE_LPD,
>  			.has_cdclk_crawl = 1,
> -			.has_modular_fia = 1,
> -			.has_psr_hw_tracking = 0,
> +			.has_modular_fia = 1
>  		};
>  		break;
>  	case XE_DG2:
> -- 
> 2.40.0
>