Re: [Intel-xe] [PATCH] fixup! drm/xe/display: Add intel_pps support too

[Rodrigo Vivi <rodrigo.vivi@kernel.org>]

On Thu, May 11, 2023 at 03:33:29PM +0300, Jani Nikula wrote:
> On Wed, 10 May 2023, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> > On Wed, May 10, 2023 at 07:02:20PM +0300, Jani Nikula wrote:
> >>This is an unrelated, unneeded change in "drm/xe/display: Add intel_pps
> >>support too".
> >>
> >>After that gets applied, "drm/xe/display: Add intel_pps support too"
> >>should itself be a fixup to "drm/xe/display: Implement display support".
> >>
> >>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >
> >
> > Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
> 
> Thanks, pushed to drm-xe-next.
> 
> Rodrigo, what would be the best way to add a git rebase todo list for
> you?

An email here is fine.

I'm going to run a git rebase clean-up today or next monday.

what do I need to do besides taking care of the fixup and remove the dummy
commits?

(my only rule is that the rebase clean-up git diff HEAD..origin/drm-xe-next needs to come empty)

> 
> 
> BR,
> Jani.
> 
> 
> >
> > Lucas De Marchi
> >
> >>---
> >> drivers/gpu/drm/i915/display/intel_pps.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
> >>index cfe40c64f6d4..c859b066e827 100644
> >>--- a/drivers/gpu/drm/i915/display/intel_pps.c
> >>+++ b/drivers/gpu/drm/i915/display/intel_pps.c
> >>@@ -481,7 +481,7 @@ static void intel_pps_get_registers(struct intel_dp *intel_dp,
> >> 				    struct pps_registers *regs)
> >> {
> >> 	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
> >>-	int pps_idx = 0;
> >>+	int pps_idx;
> >>
> >> 	memset(regs, 0, sizeof(*regs));
> >>
> >>-- 
> >>2.39.2
> >>
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center