Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@kernel.org>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 1/1] drm/xe: Enable the compat ioctl functionality
Date: Fri, 5 May 2023 10:50:50 -0400	[thread overview]
Message-ID: <ZFUXyufEB1Rflvpl@rdvivi-mobl4> (raw)
In-Reply-To: <d413ac6e-f1b8-7e47-418e-639864626bfa@linux.intel.com>

On Tue, Apr 25, 2023 at 09:46:54AM +0200, Thomas Hellström wrote:
> 
> On 4/25/23 04:19, Christopher Snowhill wrote:
> > This is required at the minimum for the DRM UAPI to function from
> > 32-bit userspace with a 64-bit kernel.
> > 
> > Signed-off-by: Christopher Snowhill <kode54@gmail.com>
> 
> LGTM.
> 
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

Pushed. thanks for the patch and review.

> 
> 
> > ---
> >   drivers/gpu/drm/xe/xe_device.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> > index 45d6e5ff47fd..00f1d9e386f1 100644
> > --- a/drivers/gpu/drm/xe/xe_device.c
> > +++ b/drivers/gpu/drm/xe/xe_device.c
> > @@ -113,7 +113,7 @@ static const struct file_operations xe_driver_fops = {
> >   	.mmap = drm_gem_mmap,
> >   	.poll = drm_poll,
> >   	.read = drm_read,
> > -//	.compat_ioctl = i915_ioc32_compat_ioctl,
> > +	.compat_ioctl = drm_compat_ioctl,
> >   	.llseek = noop_llseek,
> >   };

  reply	other threads:[~2023-05-05 14:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25  2:19 [Intel-xe] [PATCH 0/1] Enable compat ioctl functionality Christopher Snowhill
2023-04-25  2:19 ` [Intel-xe] [PATCH 1/1] drm/xe: Enable the " Christopher Snowhill
2023-04-25  7:46   ` Thomas Hellström
2023-05-05 14:50     ` Rodrigo Vivi [this message]
2023-04-25  2:22 ` [Intel-xe] ✓ CI.Patch_applied: success for Enable " Patchwork
2023-04-25  2:23 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-04-25  2:27 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-04-25  2:49 ` [Intel-xe] ○ CI.BAT: info " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFUXyufEB1Rflvpl@rdvivi-mobl4 \
    --to=rodrigo.vivi@kernel.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox